refactor: updated sdk to use setErrorDetails fn #2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
abhilash-sivan
commented
Dec 10, 2025
| expectations = expectations.concat([ | ||
| span => expect(span.ec).to.equal(1), | ||
| span => expect(span.data.sdk.custom.tags.message).to.contain('Error: Boom!\n'), | ||
| span => expect(span.data.sdk.custom.tags.message).to.contain('packages/collector/test/tracing/sdk/app.js') |
Contributor
Author
There was a problem hiding this comment.
Removed this check because earlier it was coming from getErrorDetails and this was substring of error.stack. Now this is only error.message and thus the app path is not available
kirrg001
reviewed
Dec 10, 2025
kirrg001
approved these changes
Dec 10, 2025
abhilash-sivan
added a commit
that referenced
this pull request
Dec 17, 2025
abhilash-sivan
added a commit
that referenced
this pull request
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-63749
Extended the setErrorDetails function to the SDK module.