-
Notifications
You must be signed in to change notification settings - Fork 912
feat: add github_enterprise_actions_hosted_runner #3017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…reduce change confusion
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
…vider-github into go-github-v68
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
Hey @nico34638 👋 Thank you very much for your contribution! We're currently working on a major release of the provider and that will possibly delay getting this PR merged. While that's happening, could I bother you for a few changes?
Support for Hosted runners for enterprises was added in v70 of go-github. Our upcoming major release will upgrade to v77. Could you rebase your branch on top of #2891 and use the SDK methods instead of manual HTTP requests? :) |
|
Okay, I made the changes you requested. I rebased on your branch with go github/v77 and changed the description fields. Is that okay with you? I tested it, and with the changes, it still works. |
Resolves #3016
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!