[MAINT] Convert legacy Schema Migrations to use StateUpgraders #3018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
- Renamed TESTARGS to COVERAGEARGS for clarity. - Added variable references and examples for test-specific variables. - Improved test and acceptance test commands to include branch information and coverage options. Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…ers` for schema migrations Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…ema migrations Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…tionWebhook` schema migrations to use StateUpgraders Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…ders Signed-off-by: Timo Sand <timo.sand@f-secure.com>
deiga
force-pushed
the
upgrade-state-migrations
branch
from
a8a425c to
6f218b9
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is stacked on top of #3020
Review and merge that first
resourceGithubActionsOrganizationSecretto useStateUpgradersfor schema migrationsresourceGithubActionsSecretto useStateUpgradersfor schema migrationsresourceGithubRepositoryWebhookandresourceGithubOrganizationWebhookschema migrations to use StateUpgradersresourceGithubRepositoryschema migration to use StateUpgradersBefore the change?
MigrateStatewhich is from 0.11 of the SDKgithub_actions_organization_secretgithub_actions_secretgithub_repository_webhookgithub_repositoryAfter the change?
StateUpgraderswhich is the default since 0.12 of the SDKPull request checklist
Schema migrations have been created if needed (example)Does this introduce a breaking change?
Please see our docs on breaking changes to help!