chore: add testnet initialization script #554
Conversation
bvotteler
left a comment
bvotteler
left a comment
There was a problem hiding this comment.
LGTM
Just one question: Are we okay with all constructed markets pointing to kusama/kintsugi related currencies like KSM, KBTC, and KINT even if this is called with with-defaults-of="testnet-interlay" (or parachain-endpoint of interlay testnet)?
scripts/init-testnet.ts
Outdated
| [{ Token: "KBTC" }, { ForeignAsset: 2 }, 20_000], // movr | ||
| [{ Token: "KINT" }, { ForeignAsset: 2 }, 35_000], // movr | ||
| ]; | ||
| const basicPoolSetup = pools.map(([token1, token2, reward]) => { |
There was a problem hiding this comment.
You may need to explicitly indicate types for the tuple so TS knows which types to expect.
IIRC, it will think it could be any of the tuple's internal types, ie. treating the input as array of mixed types rather than a tuple.
Good point, I think I'll leave testnet-interlay for a future pr |
sander2
force-pushed
the
chore/testnet-init-script
branch
from
830f310 to
e1aaa5b
Compare
gregdhill
force-pushed
the
chore/testnet-init-script
branch
from
10cff71 to
c05843a
Compare
sander2
force-pushed
the
chore/testnet-init-script
branch
from
34bfe03 to
7d2fb48
Compare
scripts/init-testnet.ts
Outdated
| api.tx.dexStable.addLiquidity( | ||
| metaPoolId, | ||
| [ | ||
| "10_000_000_000_000", // 10 KSM |
There was a problem hiding this comment.
"10_000_000_000_000" gets interpreted as 140004000400040000
scripts/init-testnet.ts
Outdated
| [ | ||
| { Token: "KBTC" }, | ||
| { Token: "KSM" }, | ||
| { Token: "KBTC" }, |
There was a problem hiding this comment.
Are you sure this is the only one that need to change? Also, this not only impacts edit: looks like updateRewardSchedule, but also createPair and addLiquidity. Won't that create a problem?createPair and addLiquidity do sorting automatically. The first question is still open though
There was a problem hiding this comment.
Yes the index of the Token variant will come before ForeignAsset
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
sander2
force-pushed
the
chore/testnet-init-script
branch
from
cf927a3 to
28b69fa
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Todo: