market data api fix #1690
Open
market data api fix #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the CoinGecko API call to always request prices in USD currency, ensuring consistent results regardless of input parameters.
- Modifies URL construction to explicitly set
vs_currenciesto "usd" - Filters input arguments to only include
idsparameter
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| const url = 'https://api.coingecko.com/api/v3/simple/price?' + new URLSearchParams(args) | ||
| const url = 'https://api.coingecko.com/api/v3/simple/price?' + new URLSearchParams({ids: args.ids, vs_currencies: "usd"} ) |
There was a problem hiding this comment.
Missing closing parenthesis in URLSearchParams constructor call. The line should end with }) instead of } ).
Suggested change
| const url = 'https://api.coingecko.com/api/v3/simple/price?' + new URLSearchParams({ids: args.ids, vs_currencies: "usd"} ) | |
| const url = 'https://api.coingecko.com/api/v3/simple/price?' + new URLSearchParams({ids: args.ids, vs_currencies: "usd"}) |
|
Running Lighthouse audit... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the API call in the
coingeckofunction to ensure it always requests prices in USD, regardless of the input arguments.coingeckofunction inapi/market_data.jsnow constructs the request URL using only theidsfrom the input arguments and setsvs_currenciesto"usd"explicitly, ensuring consistent currency results.