-
Notifications
You must be signed in to change notification settings - Fork 72
Updated dependencies to depend on react version 19.2.1 #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 57801e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~230 Documentation is deployed and generated using docs.page. |
Summary of ChangesHello @maneesht, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical maintenance update, specifically upgrading the React and React DOM dependencies to version 19.2.1 across various example projects and core packages. The primary goal is to ensure all components are running on the latest stable and secure version of React, potentially mitigating known issues or vulnerabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates react and react-dom dependencies to version 19.2.1 across several package.json files, likely to address the security vulnerability mentioned in the description. My review focuses on ensuring the dependency update is applied safely and consistently. I've suggested pinning the new versions instead of using a caret range (^). Given this is a security update, pinning ensures that the exact, vetted version is always used, preventing accidental upgrades to potentially problematic future releases. This is a best practice for improving the security and stability of the project.
cabljac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks!
https://www.cve.org/CVERecord?id=CVE-2025-55182
Tanstack Query still has a peer dependency on react v19.0.0, so we should do another bump when they have updated their peer deps.