Skip to content

Conversation

@maneesht
Copy link
Collaborator

@maneesht maneesht commented Dec 3, 2025

https://www.cve.org/CVERecord?id=CVE-2025-55182

Tanstack Query still has a peer dependency on react v19.0.0, so we should do another bump when they have updated their peer deps.

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025

🦋 Changeset detected

Latest commit: 57801e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack-query-firebase/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@docs-page
Copy link

docs-page bot commented Dec 3, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~230

Documentation is deployed and generated using docs.page.

@gemini-code-assist
Copy link

Summary of Changes

Hello @maneesht, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a critical maintenance update, specifically upgrading the React and React DOM dependencies to version 19.2.1 across various example projects and core packages. The primary goal is to ensure all components are running on the latest stable and secure version of React, potentially mitigating known issues or vulnerabilities.

Highlights

  • React Version Update: The react and react-dom dependencies have been consistently updated to version ^19.2.1 across all relevant package.json files within the repository.
  • Security and Stability: This dependency update is likely a proactive measure to address potential security vulnerabilities or improve overall stability, as suggested by the linked CVE-2025-55182 in the pull request description.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates react and react-dom dependencies to version 19.2.1 across several package.json files, likely to address the security vulnerability mentioned in the description. My review focuses on ensuring the dependency update is applied safely and consistently. I've suggested pinning the new versions instead of using a caret range (^). Given this is a security update, pinning ensures that the exact, vetted version is always used, preventing accidental upgrades to potentially problematic future releases. This is a best practice for improving the security and stability of the project.

@maneesht maneesht requested review from Ehesp and cabljac and removed request for Ehesp December 3, 2025 18:01
Copy link
Collaborator

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@github-project-automation github-project-automation bot moved this to Approved [PR] in [Cloud] Open Source P0 Dec 4, 2025
@cabljac cabljac merged commit fab612f into main Dec 4, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Open Source P0 Dec 4, 2025
@cabljac cabljac deleted the mtewani/fix-react-vulnerability branch December 4, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants