Add IPinfoLite to support Lite API
#93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@silvanocerza, I have been meaning but forgot to push php#90 Fix ipv6 notations and add tests, that @rvalitov kindly implemented for us. That included some of the sanitazation fixes that you added in your PR. This introduced a merge conflict with Sorry for the confusion! |
Contributor
Author
|
No worries, I'll take care of rebasing the PR. |
silvanocerza
force-pushed
the
silvano/eng-289-add-lite-api-support-to-ipinfophp
branch
from
85299c9 to
162828c
Compare
Contributor
|
Please write a note when you're done |
Contributor
Author
|
@rvalitov Yup, think I'm done. Tests are passing now. |
max-ipinfo
reviewed
Jun 25, 2025
| } | ||
|
|
||
| // List of bogon CIDRs. | ||
| protected $bogonNetworks = [ |
Contributor
There was a problem hiding this comment.
No need to do this now, but we should refactor this duplication with src/IPinfo.php
silvanocerza
deleted the
silvano/eng-289-add-lite-api-support-to-ipinfophp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this one I went with a completely separate API too.
I had to fix some unrelated stuff in
DefaultCachebecause it was using the IP string as the key with no sanitazion. ThetestGetBatchDetailstest inIPInfoTestis using8.8.8.8/hostnameand that the cache key as/is a reserved char.I also had to change some hard coded coordinates in the tests.