Fix Lite API Details response object
#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
force-pushed
the
silvano/st-1613-ticket-no-268595-null-and-404-values-for-lite-api-response-w
branch
from
4ecbe44 to
d5aa1cd
Compare
silvanocerza
deleted the
silvano/st-1613-ticket-no-268595-null-and-404-values-for-lite-api-response-w
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
country_flag_urlfield of theDetailsobjects so it points to the right URL.It also fixes other fields that weren't being set if though we had the information to do so.
It also removes fields that can't be received from the Lite API instead of setting them to
None.I had to fix some unrelated tests failing because of a location change.