Fix nginx set_real_ip_from conf #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/_#/tickets/showTicket/6275
"${NGINX_SET_REAL_IP_FROM:-192.168.39.0/24}"with192.168.39.0/24in nginx conf templates. See below for details on why.The details
Using
${name:-…}to set a default value for a non-existing (or empty) environment variable does not work in nginx templates:Notice
"${NGINX_SET_REAL_IP_FROM:-192.168.39.0/24}"is reported, i.e.${NGINX_SET_REAL_IP_FROM:-192.168.39.0/24}is not replaced with192.168.39.0/24as hoped (and expected due to it working in many other places).It's the nginx docker image that substitutes variables in templates using
envsubst, cf. https://github.com/docker-library/docs/tree/master/nginx#using-environment-variables-in-nginx-configuration-new-in-119, butenvsubstdoes not support default values for non-existing variables: