added macro example #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for making this pull request. Once a few issues are fixed, I think this will be very helpful. When I run your fork locally, I get the following problem starting on this line: After this point, Thanks again! |
Contributor
Author
|
It worked on Julia 1.10. In 1.11 they changed the extension mechanism. If you comment out the init() code, and run it AFTER you get to the REPL, it works. I'm just not sure how to make it automatic in 1.11 yet. |
Contributor
Author
|
I used a hack that delays the eval until after |
Owner
|
Thanks for the fix! |
Owner
|
@mind6, would you be willing to advise on the proper way to unit test the new components you added? I have little experience with macros.I tried the following, but received a warning and error. @testset "before import" begin
@test length(methods(cool_function)) == 0
# warning here
@test_throws LoadError @macroexpand @cool_macro
@test !isdefined(PackageExtensionsExample,:MyExtType)
end
@testset "after import" begin
using Distributions
@test length(methods(cool_function)) == 1
@test @macroexpand @cool_macro
# error here
@test isdefined(PackageExtensionsExample,:MyExtType)
end |
Contributor
Author
|
Sure, you can try this: using Test
@testset "cool_macro" begin
tmpmod = Module()
@test try
@eval tmpmod begin
using PackageExtensionsExample
@cool_macro
end
false
catch e
e isa LoadError
end
end |
Owner
|
Thank you. Unfortunately, I'm not sure if that works. It passes both when distributions is imported and when it is not imported. I was hoping to have two tests: one showing it has an error before Distributions is imported, and a second test showing that it works after Distributions is imported. Any ideas. I fixed the other error by increasing the delay after importing Distributions: sleep(.1)
@test isdefined(PackageExtensionsExample, :MyExtType)Increasing the delay in the source code did not work. |
Contributor
Author
|
right, I guess temporary modules aren't set up as packages and it does nothing when you import another package. You might try ask on discourse if there's any way to catch a LoadError. |
Contributor
Author
|
try this: #=
You should be able run this script from any directory with any project settings.
=#
using Pkg, Test
cd(@__DIR__)
# activates the project in the script's directory
Pkg.activate(".")
# adds the local PackageExtensionsExample package to the script project (don't use Pkg.add here)
Pkg.develop(path="../")
using PackageExtensionsExample
@testset "before loading Distributions" begin
@test try
Core.eval(Main, :(
module m1
using PackageExtensionsExample
@cool_macro
end
))
false
catch e
for (exc, bt) in Base.current_exceptions()
showerror(stdout, exc, bt)
println()
end
e isa LoadError
end
end
using Distributions
@testset "after loading Distributions" begin
@test try
Core.eval(Main, :(
module m2
using PackageExtensionsExample
@cool_macro
end
))
true
catch e
false
end
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.