Skip to content

Remove use of deprecated Node APIs #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuela wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove use of deprecated Node APIs #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/userid.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ NAN_METHOD(GroupName)
struct group *group = NULL;

if ((info.Length() > 0) && info[0]->IsInt32()) {
group = getgrgid(info[0]->Int32Value());
group = getgrgid(info[0]->Int32Value(Nan::GetCurrentContext()).FromJust());
} else {
return Nan::ThrowError("you must supply the gid");
}
Expand Down Expand Up @@ -72,7 +72,7 @@ NAN_METHOD(Gids)
return Nan::ThrowError("you must supply the groupname");
}

String::Utf8Value utfname(info[0]->ToString());
v8::String::Utf8Value utfname(info.GetIsolate(), info[0]);
#ifdef __APPLE__
groups = new int[ngroups]; // malloc(ngroups * sizeof(gid_t));
#else // ifdef __APPLE__
Expand Down Expand Up @@ -115,7 +115,7 @@ NAN_METHOD(Gid)
struct group *group = NULL;

if ((info.Length() > 0) && info[0]->IsString()) {
String::Utf8Value utfname(info[0]->ToString());
v8::String::Utf8Value utfname(info.GetIsolate(), info[0]);
group = getgrnam(*utfname);
} else {
return Nan::ThrowError("you must supply the groupname");
Expand All @@ -134,7 +134,7 @@ NAN_METHOD(UserName)
struct passwd *user = NULL;

if ((info.Length() > 0) && info[0]->IsInt32()) {
user = getpwuid(info[0]->Int32Value());
user = getpwuid(info[0]->Int32Value(Nan::GetCurrentContext()).FromJust());
} else {
return Nan::ThrowError("you must supply the uid");
}
Expand All @@ -152,7 +152,7 @@ NAN_METHOD(Uid)
struct passwd *user = NULL;

if ((info.Length() > 0) && info[0]->IsString()) {
String::Utf8Value utfname(info[0]->ToString());
v8::String::Utf8Value utfname(info.GetIsolate(), info[0]);
user = getpwnam(*utfname);
} else {
return Nan::ThrowError("you must supply the username");
Expand Down