Skip to content

Fixed: BackAndroid is deprecated since RN0.44.0^. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
patlux wants to merge 1 commit into from
Closed

Fixed: BackAndroid is deprecated since RN0.44.0^. #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ Methods:
Props:


- 'detectBackAndroid' -- If true, menu context detects an Android hardware back press, closes menu and stops it from propagating and potentially causing bugs. (Default: true)
- 'detectBackPress' -- If true, menu context detects an hardware back press, closes menu and stops it from propagating and potentially causing bugs. (Default: true)
- `style` -- Overrides default style properties (user-defined style will take priority)
- `onCloseMenu` -- Handler that will be called with the state of `MenuContext`, if defined.

Expand Down
14 changes: 7 additions & 7 deletions src/menu/makeMenuContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = (React, ReactNative, { constants, model, styles }) => {
TouchableWithoutFeedback,
ScrollView,
View,
BackAndroid
BackHandler
} = ReactNative;
const AnimatedOptionsContainer = require('./makeAnimatedOptionsContainer')(React, ReactNative);

Expand Down Expand Up @@ -51,11 +51,11 @@ module.exports = (React, ReactNative, { constants, model, styles }) => {
const MenuContext = React.createClass({
displayName: 'MenuContext',
propTypes: {
detectBackAndroid: React.PropTypes.bool,
detectBackPress: React.PropTypes.bool,
},
getDefaultProps() {
return {
detectBackAndroid: true,
detectBackPress: true,
};
},
mixins: [TimerMixin],
Expand Down Expand Up @@ -130,7 +130,7 @@ module.exports = (React, ReactNative, { constants, model, styles }) => {
// Only do this once on initial layout.
this.onLayout = once(this.onLayout);
},
handleBackAndroid() {
handleBackPress() {
if (this.isMenuOpen()){
this.closeMenu();
return true;
Expand All @@ -148,9 +148,9 @@ module.exports = (React, ReactNative, { constants, model, styles }) => {
console.warn(`Menu ${name} has already been registered in this context. Please provide a different name.`);
}

if (this.props.detectBackAndroid){
BackAndroid.removeEventListener('hardwareBackPress', this.handleBackAndroid); //Override previous listener
BackAndroid.addEventListener('hardwareBackPress', this.handleBackAndroid);
if (this.props.detectBackPress){
BackHandler.removeEventListener('hardwareBackPress', this.handleBackPress); //Override previous listener
BackHandler.addEventListener('hardwareBackPress', this.handleBackPress);
}
this._menus[name] = hooks;
},
Expand Down