-
Notifications
You must be signed in to change notification settings - Fork 292
Solve the problem that toast cannot be cleared in strict mode #3413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kalu5
wants to merge
3
commits into
jdf2e:feat_v3.x
Choose a base branch
from
kalu5:fix/toast
base: feat_v3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+133
−7
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: jdf2e/nutui-react
Length of output: 89
🏁 Script executed:
Repository: jdf2e/nutui-react
Length of output: 891
🏁 Script executed:
Repository: jdf2e/nutui-react
Length of output: 138
🏁 Script executed:
# Read the toast.tsx file to understand the full context cat -n src/packages/toast/toast.tsxRepository: jdf2e/nutui-react
Length of output: 3281
🏁 Script executed:
Repository: jdf2e/nutui-react
Length of output: 133
🏁 Script executed:
Repository: jdf2e/nutui-react
Length of output: 88
🏁 Script executed:
Repository: jdf2e/nutui-react
Length of output: 88
🏁 Script executed:
# Read the Notification.tsx file to see ID generation logic cat -n src/packages/toast/Notification.tsxRepository: jdf2e/nutui-react
Length of output: 5558
🏁 Script executed:
Repository: jdf2e/nutui-react
Length of output: 4039
🏁 Script executed:
Repository: jdf2e/nutui-react
Length of output: 493
🏁 Script executed:
Repository: jdf2e/nutui-react
Length of output: 2062
此实例跟踪逻辑存在无法到达的代码路径。
您的分析是正确的。当回调执行时,
messageInstance已在第 42 行被设置为null,因此第 59 行的oldInstance始终为null。这导致第 60 行的条件notification.id === oldInstance?.id始终为false(比较notification.id === undefined),使得messageInstanceSet.add(oldInstance)的代码路径无法到达。即使用户显式提供相同的 ID,该条件也永远不会成立。
clone()调用同样是多余的,因为oldInstance总是null。这段代码看起来意图是为了追踪多个实例,但由于逻辑流程的缺陷,实例集合的管理机制无法正常工作。建议审查实例追踪的设计意图,确定是否需要修改
getInstance的逻辑(例如在销毁前保存旧实例)或移除无效的追踪代码。🤖 Prompt for AI Agents