Skip to content

Conversation

@dimaqq
Copy link
Contributor

@dimaqq dimaqq commented May 21, 2025

Description

Disable the test that fails on all Juju versions.

I suspect that it's due base incompatibility:

  • ubuntu goes first and is available on 24.04
  • ntp goes next, but it tops out at 22.04 on the default channel

Ref: #1267

@dimaqq dimaqq requested review from Aflynn50 and benhoyt May 21, 2025 09:48
@dimaqq
Copy link
Contributor Author

dimaqq commented May 21, 2025

This PR only addresses the one test that fails across all juju versions.
It does not address the other 8 tests that fail on Juju 3.3 specifically.

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks okay to me, thanks.

Integration tests are now failing with a couple of "juju.errors.JujuError: base: ubuntu@24.04/stable" errors. Boy, that's not a very helpful error message, is it? Are we missing part of the error?

@dimaqq
Copy link
Contributor Author

dimaqq commented May 21, 2025

/build

@dimaqq dimaqq requested a review from gfouillet May 21, 2025 23:45
@dimaqq
Copy link
Contributor Author

dimaqq commented May 22, 2025

/merge

@dimaqq
Copy link
Contributor Author

dimaqq commented May 22, 2025

@benhoyt nope, that's that's the whole error that Juju 3.3 sends in the jRPC response. It basically means something like "field base, bad value ubuntu@24.04/stable".

@jujubot jujubot merged commit 36c7913 into juju:main May 22, 2025
21 of 29 checks passed
@dimaqq dimaqq mentioned this pull request May 23, 2025
jujubot added a commit that referenced this pull request May 25, 2025
#1271

#### Description

PR to release python-libjuju 3.6.1.2


Runtime fixes:
- #1265 

Typing fixes:
- #1258

Chores & CI:
- #1268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants