fix(controller): use consistent ID format for agent deletion #1178
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent deletion was failing to soft-delete database records because handleAgentDeletion used raw namespace/name format while upsertAgent stored agents with the Python-converted format (namespace__NS__name). Fixes kagent-dev#1175 Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
syedazeez337
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
EItanya
approved these changes
Dec 29, 2025
Contributor
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
Great catch, thanks for the contribution!
Contributor
Author
|
I will check the failing tests and get back |
Contributor
I'm 99% sure that failure is either a flake or something unrelated to your change. Once the rest of the tests finish I will try to run it again. |
Contributor
|
Merged this because the CI issue was fixed in #1182 |
Contributor
Author
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent deletion was failing to soft-delete database records because handleAgentDeletion used raw namespace/name format while upsertAgent stored agents with the Python-converted format (namespace__NS__name).
Fixes #1175