Feature official Go MCP SDK #26

dimetron · 2025-09-27T00:04:15Z

Migrated to Official Go MCP SDK

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

# Conflicts: # go.mod # go.sum

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Copilot

Pull Request Overview

This PR migrates the KAgent Tools project from an unofficial MCP SDK (github.com/mark3labs/mcp-go) to the official Model Context Protocol Go SDK (github.com/modelcontextprotocol/go-sdk). The migration includes updates across all tool categories, test files, and server implementation to use the new SDK patterns and APIs.

Updates all MCP-related imports from mark3labs/mcp-go to the official github.com/modelcontextprotocol/go-sdk/mcp
Refactors tool registration and handler implementations to match the new SDK's API structure
Updates test files to work with the new SDK's types and patterns

Reviewed Changes

Copilot reviewed 39 out of 42 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/integration/*.go	New comprehensive integration tests for the MCP SDK migration
test/e2e/helpers_test.go	Updated to placeholder MCP client functionality pending new SDK client
test/e2e/cli_test.go	Minor cleanup to handle response body closing
pkg/utils/*.go	Updated to use new SDK types and patterns for tool registration
pkg/prometheus/*.go	Migrated tool handlers and registration to new SDK format
pkg/k8s/*.go	Extensive refactoring to use new SDK API structure

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

test/integration/comprehensive_integration_test.go

pkg/k8s/k8s.go

pkg/utils/common.go

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

- fix k8s get events format - default wide Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Copilot

Pull Request Overview

Copilot reviewed 43 out of 46 changed files in this pull request and generated 6 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-03T19:42:20Z

pkg/utils/datetime_test.go

+	request := &mcp.CallToolRequest{
+		Params: &mcp.CallToolParamsRaw{
+			Name:      "datetime_get_current_time",
+			Arguments: json.RawMessage(`{}`),
+		},
+	}


The Name field is being set in CallToolParamsRaw but based on the new SDK structure, this field may not be needed or correctly placed. Verify that the tool name is properly configured in the MCP request structure.

Copilot · 2025-10-03T19:42:21Z

pkg/utils/common.go

+		var args map[string]interface{}
+		if err := json.Unmarshal(request.Params.Arguments, &args); err != nil {
+			return &mcp.CallToolResult{
+				Content: []mcp.Content{&mcp.TextContent{Text: "failed to parse arguments"}},


The error message 'failed to parse arguments' doesn't provide enough context about what went wrong. Consider including the original error details to help with debugging.

Suggested change

Content: []mcp.Content{&mcp.TextContent{Text: "failed to parse arguments"}},

Content: []mcp.Content{&mcp.TextContent{Text: fmt.Sprintf("failed to parse arguments: %v", err)}},

Copilot · 2025-10-03T19:42:21Z

pkg/prometheus/prometheus.go

+		}, nil
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()


[nitpick] Using anonymous function in defer when a simple method call would suffice adds unnecessary complexity. Consider using defer resp.Body.Close() directly.

Suggested change

defer func() { _ = resp.Body.Close() }()

defer resp.Body.Close()

Copilot · 2025-10-03T19:42:21Z

pkg/k8s/k8s.go

 	if _, err := tmpFile.WriteString(manifest); err != nil {
-		tmpFile.Close()
-		return mcp.NewToolResultError(fmt.Sprintf("Failed to write to temp file: %v", err)), nil
+		_ = tmpFile.Close()


Error handling is being silently ignored. If this fails, it could indicate a serious problem with file system operations. Consider logging the error or handling it appropriately.

Suggested change

_ = tmpFile.Close()

if closeErr := tmpFile.Close(); closeErr != nil {

logger.Get().Error("Failed to close temp file after write error", "error", closeErr, "file", tmpFile.Name())

}

Copilot · 2025-10-03T19:42:22Z

pkg/prometheus/prometheus_test.go

+func createCallToolRequest(args map[string]interface{}) *mcp.CallToolRequest {
+	argsJSON, _ := json.Marshal(args)
+	return &mcp.CallToolRequest{
+		Params: &mcp.CallToolParamsRaw{
+			Arguments: argsJSON,
+		},
+	}
+}


The json.Marshal error is being silently ignored with _. In test code, this could lead to subtle bugs if marshaling fails. Consider handling the error or using require.NoError in the test context.

Copilot · 2025-10-03T19:42:22Z

pkg/k8s/k8s.go

-		return mcp.NewToolResultError("resource_type, resource_name, and annotation_key parameters are required"), nil
-	}
+// RegisterTools registers all k8s tools with the MCP server
+func RegisterTools(server *mcp.Server, llm llms.Model, kubeconfig string) error {


The function signature accepts an llm parameter but it's not used in most of the registered tools. Consider if this parameter is still needed or if it should be optional for tools that don't require LLM functionality.

- allow filter tools in helm - fix k8s get events format - default wide Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

- fix k8s get events format - default wide - added helm template - added argocd cli Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron · 2025-10-29T11:44:04Z

latest argo-rollouts cli has several CVE's

added temporary WA in the Dockerfile
submitted PR chore(deps): update dependencies, cleanup trivy report from CVE's argoproj/argo-rollouts#4515

Copilot

Pull Request Overview

Copilot reviewed 57 out of 61 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-29T11:46:38Z

test/integration/http_transport_sdk_test.go

+	t.Log("✅ HTTP Error Handling test PASSED (implementation complete)")
+}
+
+// createHTTPTransport creates an HTTP transport for testing


The function createHTTPTransport is declared in the comment on line 333 but its implementation is not shown in the diff. This appears to be an incomplete code snippet. Ensure the function implementation is included or the comment should be removed if the function is defined elsewhere.

Copilot · 2025-10-29T11:46:39Z

internal/commands/builder_test.go

 }

 func TestHelmInstall(t *testing.T) {
 	releaseName := "test-release"


Changed Helm chart reference from bitnami/nginx to chainguard/nginx. Ensure that the chainguard/nginx chart is consistently available and accessible in test environments. If this change is intentional for security or reliability reasons, consider documenting the rationale.

Suggested change

releaseName := "test-release"

releaseName := "test-release"

// Using 'chainguard/nginx' chart instead of 'bitnami/nginx' for improved security and reliability.

// Ensure the 'chainguard' Helm repository is added and accessible in test environments.

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Resolves TODO in cmd/main.go line 253 by implementing ToolRegistry support for all tool providers (k8s, helm, istio, argo, cilium, prometheus). Changes: - Added ToolRegistry interface to all tool providers - Created RegisterToolsWithRegistry functions alongside existing RegisterTools - Updated main.go to pass ToolRegistry to all providers in HTTP mode - HTTP transport now discovers and executes tools from all providers - Backward compatibility maintained for stdio mode (registry is optional) HTTP Transport Verification: - Server starts successfully with all tool providers - Tool discovery endpoint lists all registered tools (29 tools from k8s+helm+istio tested) - Tool execution works correctly via HTTP POST - All tools properly registered with both MCP server and ToolRegistry Closes #TODO-253

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Copilot

Pull Request Overview

Copilot reviewed 65 out of 73 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T23:11:17Z

test/integration/http_transport_sdk_test.go

+	t.Log("✅ HTTP Error Handling test PASSED (implementation complete)")
+}
+
+// createHTTPTransport creates an HTTP transport for testing


The comment indicates a function definition should follow, but the actual function implementation is missing from the diff. This appears to be an incomplete code block that would cause compilation errors.

Suggested change

// createHTTPTransport creates an HTTP transport for testing

// createHTTPTransport creates an HTTP transport for testing

func createHTTPTransport(serverURL string) mcp.Transport {

return mcp.NewHTTPTransport(serverURL, nil)

}

- http transport fixes Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

✅ TOOLS_ISTIO_VERSION=1.28.0 == 1.28.0 ✅ TOOLS_HELM_VERSION=3.19.1 == v3.19.1 Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Copilot

Pull Request Overview

Copilot reviewed 59 out of 77 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

pkg/utils/common.go:1

[nitpick] Empty line 200 appears unnecessary between the condition check and the comment. Remove for cleaner code formatting.

// Package utils provides common utility functions and tools.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-12T03:46:54Z

test/e2e/helpers_test.go

 		Version: "1.0.0",
+	}, nil)
+
+	// Create HTTP transport for the MCP server


The StreamableClientTransport struct initialization lacks context. Consider adding a comment explaining that this transport connects to the MCP server running in the Kubernetes cluster via NodePort 30885.

Suggested change

// Create HTTP transport for the MCP server

// Create HTTP transport for the MCP server

// This transport connects to the MCP server running in the Kubernetes cluster via NodePort 30885.

Copilot · 2025-11-12T03:46:55Z

pkg/k8s/k8s.go

 	if _, err := tmpFile.WriteString(manifest); err != nil {
-		tmpFile.Close()
-		return mcp.NewToolResultError(fmt.Sprintf("Failed to write to temp file: %v", err)), nil
+		_ = tmpFile.Close()


[nitpick] Error from tmpFile.Close() is silently discarded. Since this is in an error path where file writing failed, this is acceptable. However, consider logging this error for better debugging.

Suggested change

_ = tmpFile.Close()

if closeErr := tmpFile.Close(); closeErr != nil {

logger.Get().Error("Failed to close temporary file after write error", "error", closeErr, "file", tmpFile.Name())

}

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron added 5 commits September 25, 2025 03:55

updated dependencies

3c8fd5a

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

ci go-version: "1.25"

eb95e9f

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

fix agentgateway config

29716b4

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Official MCP Go SDK implementation - alfa version

cdc1cd3

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Updated docs

0bbe6d2

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron self-assigned this Sep 27, 2025

dimetron requested a review from EItanya as a code owner September 27, 2025 00:04

dimetron marked this pull request as draft September 27, 2025 00:04

dimetron added 3 commits September 27, 2025 02:04

Merge branch 'main' into feature/mcp-sdk

0b791f9

# Conflicts: # go.mod # go.sum

Updated docs

1f4fcf1

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

linter error fixes

5304ef5

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron requested review from Copilot and removed request for EItanya September 27, 2025 03:16

Copilot AI reviewed Sep 27, 2025

View reviewed changes

test/integration/comprehensive_integration_test.go Outdated Show resolved Hide resolved

pkg/k8s/k8s.go Show resolved Hide resolved

pkg/utils/common.go Show resolved Hide resolved

dimetron added 2 commits October 1, 2025 14:58

fix stdio

d408f69

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

- allow filter tools in helm

09dad37

- fix k8s get events format - default wide Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron requested a review from Copilot October 3, 2025 19:40

Copilot AI reviewed Oct 3, 2025

View reviewed changes

dimetron added 3 commits October 4, 2025 03:08

- fixed e2e

1947ccb

- allow filter tools in helm - fix k8s get events format - default wide Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

- allow filter tools

cde08d7

- fix k8s get events format - default wide - added helm template - added argocd cli Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

- fixed test coverage

8c9f03c

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron requested a review from Copilot October 29, 2025 11:44

Copilot AI reviewed Oct 29, 2025

View reviewed changes

dimetron added 2 commits November 3, 2025 14:43

http transport wip

bff9043

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron force-pushed the feature/mcp-sdk branch from 8b7da30 to dfb4a39 Compare November 4, 2025 22:58

http transport wip

ab024aa

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron force-pushed the feature/mcp-sdk branch from dfb4a39 to ab024aa Compare November 4, 2025 23:09

dimetron requested a review from Copilot November 4, 2025 23:10

Copilot AI reviewed Nov 4, 2025

View reviewed changes

dimetron added 11 commits November 6, 2025 01:43

- argo cd added

d2bcb89

- http transport fixes Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

sleep tool

a7d8d4f

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

sleep task with progress

4521d9a

argocd tool secret

eb75bed

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

sleep with ProgressNotification

72947af

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

some code cleanup

ae2825e

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

rename utils tool

1b87a93

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

rename utils tool

6a33e2c

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

fix e2e

0c9457d

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

✅ TOOLS_ARGO_CLI_VERSION=3.2.0 == v3.2.0

8b53aa8

✅ TOOLS_ISTIO_VERSION=1.28.0 == 1.28.0 ✅ TOOLS_HELM_VERSION=3.19.1 == v3.19.1 Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

fixes e2e

e09261e

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron requested a review from Copilot November 12, 2025 03:46

Copilot AI reviewed Nov 12, 2025

View reviewed changes

versions updates

80fec39

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

dimetron closed this Nov 18, 2025

	Content: []mcp.Content{&mcp.TextContent{Text: "failed to parse arguments"}},
	Content: []mcp.Content{&mcp.TextContent{Text: fmt.Sprintf("failed to parse arguments: %v", err)}},

	defer func() { _ = resp.Body.Close() }()
	defer resp.Body.Close()

-		_ = tmpFile.Close()
+		if closeErr := tmpFile.Close(); closeErr != nil {
+			logger.Get().Error("Failed to close temp file after write error", "error", closeErr, "file", tmpFile.Name())
+		}

	// Create HTTP transport for the MCP server
	// Create HTTP transport for the MCP server
	// This transport connects to the MCP server running in the Kubernetes cluster via NodePort 30885.

Feature official Go MCP SDK #26

Feature official Go MCP SDK #26

Uh oh!

Conversation

dimetron commented Sep 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

dimetron commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants