-
Notifications
You must be signed in to change notification settings - Fork 213
Separate conformance tests modules from main tests #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/hold |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/cc @jaellio |
|
@rikatz: GitHub didn't allow me to request PR reviews from the following users: jaellio. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
<3 <3 <3 /approve I see a hold on here, so will hold off on LGTM and let others give final stamp. But this is great. Thank you so much! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
a heads up I didn't had time to tackle, https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/.github/dependabot.yml may need some updates as well (as @mikemorris also identified on GW API today). If no one arrives on this PR by tomorrow I will try to fix it, otherwise I can do as a followup |
| replace sigs.k8s.io/gateway-api-inference-extension => ../ | ||
|
|
||
| require ( | ||
| sigs.k8s.io/gateway-api v1.3.1-0.20251106052652-079e4774d76b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this to the latest version (1.4)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaellio updating the Gateway API version kinds of break the conformance because creq.HTTPPort is not available. I will check which commit removed it and what this was replaced for, but maybe it is worth doing on a different PR? Otherwise I can do it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I can see this is at main and even being called v1.3.1 it is indeed pointing to a commit from monthly release (https://github.com/kubernetes-sigs/gateway-api/releases/tag/monthly-2025.12) so we may be good to go
|
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Separate conformance test modules from main modules, removing the dependency of Gateway API version.
Which issue(s) this PR fixes: