Skip to content

Conversation

@vyncent-t
Copy link
Contributor

Summary

image

Ran FastPass and it seems there is an issue when using white text and orange background. I have tried adjusting the background color to be darker to match allowed contrast, but this results in the "allowed" orange basically being just red. (Please refer to the image above for details)

This clashes with the red color used for failures so I am opting for a use of black text when displaying orange labels in light mode.

Changes

  • Adjusts label text color to black when on light mode

Steps to Test

  1. Navigate to a resource that is displaying warning label
  2. Note that the white text is now black
  3. Run FastPass if available and observe no issues

Screenshots

Before

image

After

image

@vyncent-t vyncent-t self-assigned this Dec 17, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vyncent-t
Once this PR has been reviewed and has the lgtm label, please assign joaquimrocha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vyncent-t vyncent-t added frontend Issues related to the frontend a11y Accessibility related issues and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2025
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility related issues cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. frontend Issues related to the frontend size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants