Fix: Use WriteHeader in json method for consistent status handling #2866
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Problem
The
json()method incontext.go(line 504) was inconsistent with other response methods in how it sets the HTTP status code.Current behavior:
This approach directly sets the
Statusfield instead of properly callingWriteHeader(), which bypasses header commitment and prevents warnings about header modifications after the status is set.Solution
Updated the method to use
c.response.WriteHeader(code)for consistency with other response methods:All other similar response methods already use
WriteHeader():jsonPBlob()- line 489:c.response.WriteHeader(code)xml()- line 543:c.response.WriteHeader(code)Blob()- line 578:c.response.WriteHeader(code)JSONPBlob()- line 530:c.response.WriteHeader(code)