[Merged by Bors] - feat: IsStrictOrderedRing (Lex R⟦Γ⟧)
#33398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
large-import
PR summary ce5b0921e0Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.HahnSeries.Lex | 651 | 862 | +211 (+32.41%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.HahnSeries.HahnEmbedding |
6 |
Mathlib.Algebra.Order.Module.HahnEmbedding |
57 |
Mathlib.RingTheory.HahnSeries.Lex |
211 |
Declarations diff
+ instance [IsOrderedRing R] [NoZeroDivisors R] : IsOrderedRing (Lex R⟦Γ⟧)
+ instance [IsStrictOrderedRing R] : IsStrictOrderedRing (Lex R⟦Γ⟧)
+ leadingCoeff_mul
+ leadingCoeff_mul_of_ne_zero
+ orderTop_mul
+ orderTop_mul_of_ne_zero
+ order_mul_of_ne_zero
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Decrease in tech debt: (relative, absolute) = (1.00, 0.01)
| Current number | Change | Type |
|---|---|---|
| 143 | -1 | flexible linter exceptions |
Current commit b2622002b7
Reference commit ce5b0921e0
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
wwylele
approved these changes
Dec 31, 2025
YaelDillies
approved these changes
Dec 31, 2025
Collaborator
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
leanprover-community-mathlib4-bot
added
the
maintainer-merge
Member
|
Thanks! bors d+ |
Contributor
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
vihdzp
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
Collaborator
Author
|
bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded! And happy new year! 🎉 |
mathlib-bors
bot
changed the title
IsStrictOrderedRing (Lex R⟦Γ⟧)IsStrictOrderedRing (Lex R⟦Γ⟧)
kim-em
pushed a commit
to kim-em/mathlib4
that referenced
this pull request
Jan 6, 2026
Used in the CGT repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in the CGT repo.
I don't know if it's possible to relax
RingtoSemiring.