Skip to content

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Apr 12, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

Describe the changes included in this pull request. Link to the associated GitHub issue(s).

  • fixes Deploy Storybook #122
  • Added the GitHub Actions workflows to deploy Storybook to AWS.
  • Updated the CI GitHub Actions workflow to validate the Storybook CloudFormation template.

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

  1. The CI workflow will be tested by this PR.
  2. The DEV Storybook deployment has been tested by applying the dev tag.
  3. The QA and PROD Storybook deployments will be tested as part of the next release.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • [...]

@mwarman mwarman self-assigned this Apr 12, 2025
@mwarman mwarman linked an issue Apr 12, 2025 that may be closed by this pull request
@mwarman mwarman requested a review from Copilot April 12, 2025 10:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.aws/cfn/storybook.yml:36

  • [nitpick] The bucket name pattern 'reactstarter-ui-sb' differs from the domain naming used in Route53 records (e.g., 'react-starter-storybook'). Consider aligning these naming conventions for clarity and consistency across resources.
BucketName: !Sub
        - 'reactstarter-ui-sb.${HostedZone}-${AWS::Region}-${AWS::AccountId}'

@mwarman mwarman marked this pull request as ready for review April 14, 2025 10:02
@mwarman mwarman marked this pull request as draft April 14, 2025 10:03
@mwarman mwarman marked this pull request as ready for review April 14, 2025 11:42
@mwarman mwarman requested a review from Copilot April 14, 2025 11:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .github/workflows/deploy-qa.yml: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/deploy-storybook.yml:63

  • [nitpick] The input name 'env' is ambiguous; consider renaming it to 'environment_code' or a similarly descriptive name to improve clarity in the deployment configuration.
echo "VITE_BUILD_ENV_CODE=${{ inputs.env }}" >> .env

.github/workflows/deploy-app.yml:64

  • [nitpick] Using 'env' as an input name may be unclear; renaming it to 'environment_code' could make the intended purpose more explicit within the workflow.
echo "VITE_BUILD_ENV_CODE=${{ inputs.env }}" >> .env

@mwarman mwarman merged commit 6e24313 into main Apr 14, 2025
7 checks passed
@mwarman mwarman deleted the 122-deploy-storybook branch April 14, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy Storybook

2 participants