Fix Linux compilation errors in platform-specific code #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple compilation errors in the Linux platform-specific implementation files under
src/platform/linux/. The errors were preventing the library from building on Linux systems.Issues Fixed
KeyboardMonitor (
keyboard_monitor_linux.cpp)event_dispatcher_memberEmitSync()method instead of missingDispatchEvent()DispatchEvent()method implementationMenu System (
menu_linux.cpp)std::stringtoconst std::string&to match header declarations)unique_ptrmembers (removed manualdeletecalls)SetTitle,GetTitle,CreateItem)GetNativeItem()implementation for MenuItemshared_ptr<MenuItem>parameters as expected by the interfaceTrayIcon (
tray_icon_linux.cpp)shared_ptr<Menu>instead of attempting to copy non-copyable Menu objectsWindowManager (
window_manager_linux.cpp)WindowManagerImpltoImplto match header forward declarationimpl_topimpl_to match headerEmitSync()methodDisplayManager (
display_manager_linux.cpp)Testing
All Linux platform-specific files now compile successfully without errors:
The changes are minimal and surgical, focusing exclusively on fixing compilation issues while preserving all existing functionality.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.