Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/platform/windows/accessibility_manager_windows.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
#include <windows.h>
#include <oleacc.h>

#pragma comment(lib, "oleacc.lib")

namespace nativeapi {

void AccessibilityManager::Enable() {
Expand Down
3 changes: 3 additions & 0 deletions src/platform/windows/tray_icon_windows.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
#include <string>
#include <vector>
#include <memory>

#pragma comment(lib, "shell32.lib")

#include "../../tray_icon.h"
#include "../../menu.h"
#include "../../tray_icon_event.h"
Expand Down
2 changes: 2 additions & 0 deletions src/platform/windows/tray_manager_windows.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
#include <memory>
#include <mutex>

#pragma comment(lib, "shell32.lib")

#include "../../tray_icon.h"
#include "../../tray_manager.h"

Expand Down
3 changes: 3 additions & 0 deletions src/platform/windows/tray_windows.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
#include <string>
#include <vector>
#include <memory>

#pragma comment(lib, "shell32.lib")

#include "../../tray.h"
#include "../../menu.h"

Expand Down
12 changes: 6 additions & 6 deletions src/platform/windows/window_manager_windows.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
namespace nativeapi {

// Private implementation for Windows (stub for now)
class WindowManager::WindowManagerImpl {
class WindowManager::Impl {
public:
WindowManagerImpl(WindowManager* manager) : manager_(manager) {}
~WindowManagerImpl() {}
Impl(WindowManager* manager) : manager_(manager) {}
~Impl() {}

void SetupEventMonitoring() {
// TODO: Implement Windows-specific event monitoring
Expand All @@ -29,7 +29,7 @@ class WindowManager::WindowManagerImpl {
WindowManager* manager_;
};

WindowManager::WindowManager() : impl_(std::make_unique<WindowManagerImpl>(this)) {
WindowManager::WindowManager() : pimpl_(std::make_unique<Impl>(this)) {
SetupEventMonitoring();
}

Expand All @@ -38,11 +38,11 @@ WindowManager::~WindowManager() {
}

void WindowManager::SetupEventMonitoring() {
impl_->SetupEventMonitoring();
pimpl_->SetupEventMonitoring();
}

void WindowManager::CleanupEventMonitoring() {
impl_->CleanupEventMonitoring();
pimpl_->CleanupEventMonitoring();
}

void WindowManager::DispatchWindowEvent(const Event& event) {
Expand Down
10 changes: 5 additions & 5 deletions src/platform/windows/window_windows.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ void Window::SetMinimumSize(Size size) {
// This is a placeholder implementation
}

Size Window::GetMinimumSize() {
Size Window::GetMinimumSize() const {
// Placeholder implementation
return Size{0, 0};
}
Expand All @@ -282,7 +282,7 @@ void Window::SetMaximumSize(Size size) {
// This is a placeholder implementation
}

Size Window::GetMaximumSize() {
Size Window::GetMaximumSize() const {
// Placeholder implementation
return Size{0, 0};
}
Expand Down Expand Up @@ -409,7 +409,7 @@ void Window::SetAlwaysOnTop(bool is_always_on_top) {
}
}

bool Window::IsAlwaysOnTop() {
bool Window::IsAlwaysOnTop() const {
if (pimpl_->hwnd_) {
LONG_PTR exStyle = GetWindowLongPtr(pimpl_->hwnd_, GWL_EXSTYLE);
return (exStyle & WS_EX_TOPMOST) != 0;
Expand All @@ -425,7 +425,7 @@ void Window::SetPosition(Point point) {
}
}

Point Window::GetPosition() {
Point Window::GetPosition() const {
Point point = {0, 0};

if (pimpl_->hwnd_) {
Expand All @@ -446,7 +446,7 @@ void Window::SetTitle(std::string title) {
}
}

std::string Window::GetTitle() {
std::string Window::GetTitle() const {
if (pimpl_->hwnd_) {
int length = GetWindowTextLength(pimpl_->hwnd_);
if (length > 0) {
Expand Down
10 changes: 5 additions & 5 deletions src/window.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ class Window {
void SetContentSize(Size size);
Size GetContentSize() const;
void SetMinimumSize(Size size);
Size GetMinimumSize();
Size GetMinimumSize() const;
void SetMaximumSize(Size size);
Size GetMaximumSize();
Size GetMaximumSize() const;
void SetResizable(bool is_resizable);
bool IsResizable() const;
void SetMovable(bool is_movable);
Expand All @@ -68,11 +68,11 @@ class Window {
void SetClosable(bool is_closable);
bool IsClosable() const;
void SetAlwaysOnTop(bool is_always_on_top);
bool IsAlwaysOnTop();
bool IsAlwaysOnTop() const;
void SetPosition(Point point);
Point GetPosition();
Point GetPosition() const;
void SetTitle(std::string title);
std::string GetTitle();
std::string GetTitle() const;
void SetHasShadow(bool has_shadow);
bool HasShadow() const;
void SetOpacity(float opacity);
Expand Down
Loading