types: add NVMe 2.3 opcode, fid and lid definitions #3025
Merged
+244
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikegami-t
force-pushed
the
nvme-2.3-def
branch
3 times, most recently
from
acd7603 to
f691b99
Compare
igaw
reviewed
Jan 2, 2026
Collaborator
|
Please update the formatting, the rest looks good. |
Added for NVMe 2.3 commands support. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Supported by NVMe 2.3. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since the status code is duplicated with the fw-commit status code. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
nvme-2.3-def
branch
from
dc9e369 to
5493ea6
Compare
igaw
reviewed
Jan 5, 2026
| * or a standard errno string if status is < 0. | ||
| */ | ||
| static inline const char * | ||
| nvme_opcode_status_to_string(int status, bool admin, __u8 opcode) |
Collaborator
There was a problem hiding this comment.
Ideally, we would have only one function which handles the negative error code and the postive status code. Though this should be handled in nvme-experiments#98
So let's go with this for now. It will be addressed later :)
Contributor
Author
There was a problem hiding this comment.
I see this. Thank you.
Collaborator
|
Thanks a lot. Having the library in the same repo seems to be a bliss :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added for NVMe 2.3 commands support.