change numbering filenames #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For numbering filenames, added a spin box for the starting number and a spin box for the step size of the numbering in GTK ui file. Did this for both the replace and insert widgets. Modified the Python code for the replace and insert functions accordingly. In the replace function, ignore empty find string inputs to avoid unexpected replacement behavior. The inject function has been modified to allow larger numbers with leading zeros (%n, %0n, %000000n, etc). modified: usr/lib/bulky/bulky.py modified: usr/share/bulky/bulky.ui
Contributor
Author
|
Tested locally here with Debian 13 and Cinnamon. It worked without any problems. However, this is my first GTK code patch. I hope it will be accepted after testing. :-) |
Contributor
Author
|
example: |
… of the dialog box has been increased.
screenshot
Contributor
Author
|
Glad that you adopted the change. 👍 I also removed the unnecessary import of the magic module from the script. Unfortunately, I overlooked that the now unnecessary module "python3-magic" is still listed as a build dependency in the control file. It would be great if you could remove this one line from the control file as well. 😄 |
Member
|
Done, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For numbering filenames, added a spin box for the starting number and a spin box for the step size of the numbering in GTK ui file. Did this for both the replace and insert widgets.
Modified the Python code for the replace and insert functions accordingly.
In the replace function, ignore empty find string inputs to avoid unexpected replacement behavior.
The inject function has been modified to allow larger numbers with leading zeros (%n, %0n, %000000n, etc).
fix issue #63 and #66(partly?)