[Next] util.js splitByGlyph: Use new JS native method #13347
Closed
+4
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcw
changed the title
fredcw
changed the title
mtwebster
changed the title
Member
|
This isn't available in mozjs 115 (Mint 22). I'll wait until we hop versions for 23. |
Contributor
Author
|
@mtwebstar you're right, sorry. Requires mozjs 125. I'll close for now, and reopen when appropriate. Funny thing is, I tested it and it doesn't report any errors, but on further testing, it doesn't get all the emoji correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's does exactly the same thing, just using native JS.