Provide an alternative to Adwaita symbolic icons #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There seems to be no issue with licensing: LGPL3 -> GPL3. Size is OK as well: We're looking at 700KB or so. |
clefebvre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Adwaita project no longer supports GTK applications outside of GNOME. Icons are removed and this creates regressions in applications which use them.
It's perfectly OK for Adwaita to focus on GNOME and not want to support other environments. Now that it's gone though, we need to maintain this set of icons.
This PR adds the Adwaita symbolic icons to xapp-common. These get installed in hicolor/.
It also adds migration tools to make it easy for developers to scan their source code, find and replace old icon names with new icons.