Skip to content

Conversation

@MarkIannucci
Copy link
Contributor

With the recent supply chain attack on a popular GH Action, I noticed that this action has a transitive dependency on jenseng/dynamic-uses (which is a really clever chunk of code!).

GitHub recommends pinning to a SHA to protect against these sorts of attacks which is what this PR does.

@HarshCasper HarshCasper self-requested a review March 21, 2025 13:39
@danrjohnson
Copy link

@HarshCasper Any chance we could have this reviewed and merged in?

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution, and thanks for the push towards pinned action references! That totally makes sense, and we could maybe directly move to Dependabot as well to make sure that we also regularly update to new releases of the actions.
I just think there is a bit of a mixup with the selected sha hash (see comment), afterwards we can merge this one right in and we can take over the Dependabot onboarding afterwards.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the CI currently does not properly work for runs from forks (since it cannot checkout the action properly). I updated all the digest pins and introduced a DependaBot config. I will merge this for now and verify that the CI works properly on main.

@alexrashed alexrashed merged commit 0c7554f into localstack:main Dec 9, 2025
1 check failed
@MarkIannucci MarkIannucci deleted the pin-dynamic-uses-to-hash branch December 9, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants