-
Notifications
You must be signed in to change notification settings - Fork 4
fix: fix env #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix env #5
Conversation
WalkthroughThe pull request involves updating the environment variable used for specifying the server URL in both the frontend README and the API utility file. The change transitions from Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
frontend/src/utils/api.js (1)
15-15: Remove temporary debugging logs.These console.log statements appear to be temporary debugging additions. They should be removed before merging to keep the codebase clean.
- console.log("url1", url); url = `${url}?${queryString}`; - console.log("url2", url); ... - console.log("url3", `${process.env.NEXT_PUBLIC_API_SERVER}${url}`);Also applies to: 17-17, 25-25
frontend/README.md (1)
15-15: Add migration note for existing users.While the environment variable update is documented, consider adding a note for existing users about migrating from
PARALLEL_EVM_EXPLORER_SERVERtoNEXT_PUBLIC_API_SERVER.Add this section before the environment variable example:
.env +> **Note:** If you're upgrading from a previous version, rename `PARALLEL_EVM_EXPLORER_SERVER` to `NEXT_PUBLIC_API_SERVER` in your .env file. + ```sh NEXT_PUBLIC_API_SERVER=http://<your-server-host>:<port></blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 79223d608957aa8321293e476a33f684773202bc and 97d124152de539a32ddd76bd1a5456a145095a1a. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `frontend/README.md` (1 hunks) * `frontend/src/utils/api.js` (1 hunks) </details> <details> <summary>🔇 Additional comments (1)</summary><blockquote> <details> <summary>frontend/src/utils/api.js (1)</summary> `27-27`: **Verify deployment configurations for the new environment variable.** The change from `PARALLEL_EVM_EXPLORER_SERVER` to `NEXT_PUBLIC_API_SERVER` follows Next.js conventions for public environment variables. However, this is a breaking change that requires updates to deployment configurations. Run this script to check for any remaining references to the old environment variable: </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary by CodeRabbit
Configuration
PARALLEL_EVM_EXPLORER_SERVERtoNEXT_PUBLIC_API_SERVERDevelopment