fix: add failure buckets data model back in #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With previous refactoring the failure bucket collection stage was accidentally dropped. With this commit the data is restored to the JSON report. With follow up commits it will be added back to the report itself. Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
machshev
requested review from
hcallahan-lowrisc,
martin-velay and
rswarbrick
machshev
commented
Dec 4, 2025
| """ | ||
|
|
||
| def __init__(self, results: Sequence[CompletedJobStatus]) -> None: | ||
| def __init__(self, results: Sequence["CompletedJobStatus"]) -> None: |
Collaborator
Author
There was a problem hiding this comment.
Quoted type required here to prevent circular imports.
Once we have a few more data classes, it might be worth refactoring the file structure a bit so that we can have types without quotes. Circular imports due to typing is generally a good sign that things that should be together are not.
machshev
commented
Dec 4, 2025
| """Mapping of common error message strings to the full job failure summary.""" | ||
|
|
||
| @staticmethod | ||
| def from_job_status(results: Sequence["CompletedJobStatus"]) -> "BucketedFailures": |
Collaborator
Author
There was a problem hiding this comment.
Return type needs quoting as the type is the class itself. The reference for which doesn't exist until it's been fully defined, at least as far as the class attributes and method prototypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With previous refactoring the failure bucket collection stage was accidentally dropped. With this commit the data is restored to the JSON report. With follow up commits it will be added back to the report itself.
Goes towards #61