DM-42201: Add flat metrics for mean, noise vs mjd and FP plots #308
Conversation
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
3 times, most recently
from
d597a35 to
9b34d29
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
from
9b34d29 to
2f5df70
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
from
2f5df70 to
5d39a68
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
3 times, most recently
from
cd31e49 to
1e93a60
Compare
pipelines/cpCore.yaml
Outdated
| from lsst.analysis.tools.atools import * | ||
| analyzeFlatDetMergeCore: | ||
| class: lsst.analysis.tools.tasks.VerifyCalibAnalysisTaskByFilter |
There was a problem hiding this comment.
This is calling the existing task that only has dimensions ["instrument", "physical_filter"]. We need a new task that has input data dimensions of ["instrument", "physical_filter", "detector"].
There was a problem hiding this comment.
I think this means we need to add one more task with that set of dimensions. This all needs to be cleaned up next year to avoid this problem.
There was a problem hiding this comment.
Ah, as part of this discussion, we learned there is an existing task to do this, so if that runs, and produces plots then this should be fine.
czwa
left a comment
czwa
left a comment
There was a problem hiding this comment.
Approved, provided Jenkins is successful, as the "changes requested" appear to be already implemented.
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
3 times, most recently
from
f5ab80f to
132016e
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
3 times, most recently
from
f93a0ea to
a1db508
Compare
|
Same comment as on the other PR: the rebase should get rid of the |
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
3 times, most recently
from
d1aaa2a to
4c65dbe
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
from
4c65dbe to
cc4c94e
Compare
No description provided.