Skip to content

Conversation

@timj
Copy link
Member

@timj timj commented Nov 5, 2025

These warnings were added in click by pallets/click#2397

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.95%. Comparing base (44633bb) to head (3e5877f).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   85.91%   85.95%   +0.04%     
==========================================
  Files          44       44              
  Lines        2534     2542       +8     
  Branches      260      264       +4     
==========================================
+ Hits         2177     2185       +8     
  Misses        256      256              
  Partials      101      101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge approved. I couldn't reproduce the problem with --help on the various subcommands like I can with current weekly. I also double checked that it doesn't happen with ctrl_bps in weekly.

I do find it a little confusing that pipeline_build_options does have a butler_config to skip but qgraph_options does not and line 216 explicitly calls butler_options. I think this is because with pipeline build the repo is optional (and it still works in a manual test). I don't have any suggestions on how to make it better though.

@timj timj merged commit 24947d5 into main Nov 5, 2025
24 of 25 checks passed
@timj timj deleted the tickets/DM-50896 branch November 5, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants