Fix/empty html tags cleanup #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the autoHeightBridge to enhance content detection and height measurement, including more robust handling of renderable content and element height calculation. Updated dependencies in example/package.json to latest patch versions for expo, react, react-dom, and dev tools. These changes improve reliability and maintain compatibility with the latest ecosystem updates.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of empty HTML tags in the auto-height calculation logic by introducing more sophisticated content detection and refactoring the height measurement system.
Key Changes:
- Introduced
hasRenderableContentfunction to properly detect empty HTML elements by checking for text content and media elements (images, videos, etc.) - Refactored height measurement logic to be more comprehensive and efficient
- Updated multiple dependencies to their latest patch versions (React 19.1.1, Expo 54.0.23, and related packages)
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/constants/autoHeightBridge.ts | Core fix: Added hasRenderableContent function to detect empty HTML tags and refactored height measurement to check multiple element properties and include scrollingElement |
| package.json | Bumped package version to 1.0.14 |
| example/package.json | Updated example dependencies to match latest Expo and React versions |
| yarn.lock | Lock file updates reflecting all dependency version changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.