-
Notifications
You must be signed in to change notification settings - Fork 5
feat: media content time spent calculation #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: media content time spent calculation #44
Conversation
BrandonStalnaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and has the changes I expected from the last version
9bfc9c2 to
f8a1468
Compare
jamesnrokt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good cleanup. I don't have a Roku device to run it and validate but the logic looks correct. Few minor comments
jamesnrokt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but also applied the 'wait to merge' label as I believe we can't merge until 12th without further approval. Please correct that if I'm wrong
Background
What Has Changed
Screenshots
Checklist
Reference Issue (For employees only. Ignore if you are an outside contributor)