forked from thesofproject/sof
-
Notifications
You must be signed in to change notification settings - Fork 1
topology2: change HDMI_ID according to dai links #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
macchian
wants to merge
644
commits into
master
Choose a base branch
from
mac-dev-sdw
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove buffer ops from pipeline-graph.c and pipeline-params.c this is a continuation of changes from commit 4a03699 Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
CONFIG_SDMA_SCRIPT_CODE is always defined (even if not selected it defaults to empty string) so this is not a good way of including sdma script code header file. Make use of HAVE_SDMA_FIRMWARE boolean config in order to select the sdma script code header. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
The Pulse Density Modulated Microphone Interface (MICFIL) is a popular way to deliver audio from microphones to the processor in several applications, such as mobile telephones. However, current digital-audio systems use multibit audio signal (also known as multibit PCM) to represent the signal. This block implements the required digital interface to provide a 24-bits audio signal from a PDM microphone bitstream in a configurable output sampling rate. This patch adds initial support for PDM MICFIL IP found on i.MX8MP board. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
If both SOF_PROBES and MTRACE logging backends are disabled at build time, IPC4 build failed due to undefined ipc4_logging_enable_logs(). Fixes a bug in commit 1721f70 ("logging: add logging through probes"). Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Add Vendor Config Set, a special case of Large Config Set. Large Config Set handling now checks for this case and extracts extended param_id from ipc payload as param_id and handles the rest of the payload as usual. KPB now uses extended param_id. Necessary for fast mode task configuration in KPB. Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
This patch implements handling of the configuration IPC for FMT in KPB module. KPB now saves the list of module instances to be processed by FMT. This is the first step for implementing FMT functionality. In case of WoV event, FMT is needed for KPB to drain history buffer and send this data to Host ASAP, as normal tasks are too slow. Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
This change increases the ramp duration from 20 ms to 50 ms. It lowers the peak load of peak volume component due to longer same gain value blocks. The internal update rate for gain becomes 250 us instead of 125 us. The longer fade-in ramp also conceals better possible analog capture start transients. This changes for 4ch capture for gain.11.1 in sof-hda-generic-4ch.tplg from CPU_PEAK(MAX) = 21.95 PEAK(MAX)/AVG(AVG) = 7.51 to CPU_PEAK(MAX) = 9.07 PEAK(MAX)/AVG(AVG) = 3.12 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
These topologies are no longer supported by mainline firmware code for these platforms. The stable-v2.2 branch continues to support these targets. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
All existing SSP-based topologies use the audio cardinal clock, *EXCEPT* Bluetooth related ones. This doesn't make much sense, let's use the same clock source for all SSPs. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
For TGL and TGL-H, IPC4 is the default build config, remove the '-i IPC4' option as it is not needed anymore. Signed-off-by: Chao Song <chao.song@linux.intel.com>
For legacy CAVS platforms (TGL/ADL/EHL), the default build config is IPC4 now, and the overlay file is already emptied. Remove the option in this build script. Signed-off-by: Chao Song <chao.song@linux.intel.com>
We build tgl and tgl-h with ipc4 by default, those ipc4 overlays are empty now, can be removed safely. Signed-off-by: Chao Song <chao.song@linux.intel.com>
remove buffer ops from copier module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from mixin/mixout module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from mixer modules this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from smart_amp module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from aria module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from asrc module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from chain_dma module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from kpb module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from volume module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from crossover module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
The pipeline-common.conf helps us to define several common pipeline attributes include pipeline index, there is no need to define pipeline index in each pipeline class definition if pipeline-common.conf is included. Signed-off-by: Chao Song <chao.song@linux.intel.com>
Ninja seems to have just mysteriously disappeared from https://github.com/actions/runner-images/blob/win22/20230918.1/images/win/Windows2022-Readme.md See thesofproject#8250 for more details. Let's try to install it explicitly. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
The old style is not used now. Signed-off-by: Rander Wang <rander.wang@intel.com>
Add support in gain-capture pipeline to support 4ch DMIC stream. Signed-off-by: Rander Wang <rander.wang@intel.com>
We need to care about audio user experience and peak MCPS usage in production topologies. The alsabat test is disturbed by the longer ramp so the change can be reverted from nocodec topologies. Those topologies are never used by end users. Also the peak MCPS mitigation is not relevant for test topologies, as long as higher MCPS is not triggering error reports. The curve duration is restored without explicit set to the default 20 ms. Fixes: thesofproject#8238 Fixes: d0d74a4 ("Tools: Topology2: Change in capture gain curve_duration to 50 m") Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Starting from Zephyr commit f0daf904bb02, CONFIG_PICOLIBC is on by default. PICOLIBC does not seem compatible with sparse yet: zephyrproject-rtos/zephyr#63003 Even if it were compatible with sparse, it seems like a pretty big change that we should not immediately and blindly accept. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
FW infrastructure shall support buffering of historic data from 1ch up to 6 channels 24bit samples in 24bit container. For this reason, the heap should be extended.Increase HEAPMEM_SIZE by 0x90000 because for audio format 16000Hz/6ch/24bit history_buffer_size = 16 * 6 * 3 * 2100s = 604800 bytes (0x93A80) Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com>
The file is found from subdirectory src/audio/google. Without fix if CONFIG_COMP_GOOGLE_HOTWORD_DETECT is enabled build fails: CMake Error at sof/zephyr/cmake/modules/extensions.cmake:424 (add_library): Cannot find source file: /src/audio/google_hotword_detect.c Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Print out some information from the Signed package info extension, the most important information being is the partition_usage which is used to select key slot to be used for verification. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Set the default alignment value after buffer format is set in audio_stream_set_params instead of in audio_stream_init where the buffer format hasn't been set yet. Signed-off-by: Andrula Song <andrula.song@intel.com>
Addition of SRC Lite module, which only supports a subset of conversions supported by the SRC module. Purpose of SRC Lite module is memory optimization. Code of SRC Lite is drastically reduced and requires significantly less memory. When needed one of defined conversions, driver can choose SRC Lite module instead of SRC module to optimize memory utilization. 48 -> 16kHz 44.1 -> 16 kHz 32 -> 16 kHz 44.1 -> 48 Signed-off-by: Fabiola Kwasowiec <fabiola.kwasowiec@intel.com>
This patch adds to definitions in common.conf a new class "text" to support the enum control values. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds the class for the Time domain fixed beamformer (TDFB) and example blobs for line arrays. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
assert() that sscanf returns the expected value. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Fixes compilation failure with clang 15:
rimage/src/toml_utils.c:297:67: error: taking address of packed member
'd0' of class or structure 'uuid_t' may result in an unaligned pointer
value [-Werror,-Waddress-of-packed-member]
sscanf(buf, "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x", &id.d0,
^~~~
This also aligns indexes.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Add missing `const` and warn that the endianness can't be relied on. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
A simplified copy of previous bxt.m4 is made as local platform/generic.m4 with SSP and other platform definitions for test topologies build. It is included to test-all, test-capture, and test-playback macros definitions. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
These topologies are no longer supported by mainline firmware code for these platforms. The stable-v2.2 branch continues to support these targets with topology1. Also SOF main branch provides topology2 targets for a subset of these configurations. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
When I was using xtensa to build mt8188 platform, I encountered an error: 'redefinition of i'. To fix the problem, I removed the declaration in the for loop. Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Because the size of struct comp_buffer has increased, the current heap layout for the basic use case is not enough. Some use cases are experiencing out of memory issues, c0 memory src/lib/alloc.c:765 ERROR failed to alloc 0x180 bytes zone 0x4 caps 0x1 flags 0x0 To fix this issue, we increase the number of 512-byte heap blocks to 32. Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Condense src 48k to other audio format with combined array format. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
Condense src input audio format convert to 48k in tplg file. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
Condense src format from s32 to multiple audio format. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
Condense input format to combined array for src. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
Condense passthrough audio format with combined arrays. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
Enable Google ACE for for all sof-mtl-max98357a-rt5682 variants. Signed-off-by: Yong Zhi <yong.zhi@intel.com>
Contains 600+ commits merged after 3.5.0 release, including following directly affecting SOF targets: 76cb2a54f51f intel_adsp: Do not include device_runtime header 1fac5ed2a60b soc: xtensa/nxp_adsp: put guard in Kconfig.defconfig f4cb487b79f9 modules: sof: Options only when module is available 02deea0e806a ace: alh: Only ACE1.5 has OSEL feature f0326f72498c tests: dma_loopback: Intel ADSP ACE15 disable PM adf6d0e3d80e soc: intel_adsp: lpsram enable retention mode eeb4f2f76d6d soc: intel_adsp: hpsram enable retention mode 16f729214b50 soc: intel_adsp: lpsram init refactor 112611378f85 soc: intel_adsp: hpsram init refactor cdd4d8470323 xtensa: add custom mem range check functions Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
The xt-clang RI-2022.10 compiler headers define UNUSED. The
rename of the macro for trace fixes in testbench build this
error:
In file included sof/tools/tplg_parser/pga.c:17:
In file included sof/tools/tplg_parser/
../../src/include/sof/lib/uuid.h:11:
In file included sof/tools/tplg_parser/
../../src/include/sof/common.h:105:
/home/singalsu/work/current/sof/sof/tools/tplg_parser/
../../src/include/sof/trace/preproc.h:162:9: error:
'UNUSED' macro redefined [-Werror,-Wmacro-redefined]
#define UNUSED(arg1, ...) do { META_RECURSE(
xtensa/XtDevTools/install/tools/RI-2022.10-linux/XtensaTools/
xtensa-elf/include/xtensa/xtensa-types.h:60:9:
note: previous definition is here
#define UNUSED(x) ((void)(x))
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds sof-lnl-rt711-l0-rt1316-l23-rt714-l1.tplg, which is used to support LNL RVP + AIOC4.1 codec board combination. Signed-off-by: Chao Song <chao.song@linux.intel.com>
Fixed the order in which sections are placed in the output firmware image for platforms using a simple manifest. Fixes: thesofproject#8336 Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Fixes commit deed9a8 ("scripts: fuzz: add support for build and overlays") The main issue was the way fuzz.sh was trying to parse the overlay file. Drop that and just pass it as is to `west` and `cmake` instead, they know what to do with it. Also: - Fix invalid syntax in stub_build_all_ipc4.conf - Make fuzz.sh shellcheck-clean again. Always use shellcheck. - Temporarily disable `CONFIG_COMP_SMART_AMP` in stub_build_all_ipc3.conf because `smart_amp.c` does not compile (in any configuration) ``` sof/src/audio/smart_amp/smart_amp.c:748:9: error: no member named 'in_channels' in 'struct smart_amp_data' sad->in_channels = audio_stream_get_channels(&source_buffer->stream); ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Clean cherry-picks of two commits from separate rimage repo https://github.com/thesofproject/rimage/commits/stable-v2.7 This will properly setup partition_usage field and remove fixed 0x23 value from MTL toml Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com> (cherry picked from commit fbea59358d06ffa86645cdf4ce0996e352742eb5) Second, squashed LNL commit: config/lnl.toml: drop now invalid signed_pkg.partition_usage Fixes commit fbea59358d06 ("rimage: mtl: fix key slot setup based on imr type") which broke LNL compilation like this: ``` error: 1 unparsed keys left in 'signed_pkg' error: key 'signed_pkg' parsing error ``` This commit does not change the final image (compared to before rimage commit fbea59358d06) because the default value is now 0x20 + IMR type. Fixes are normally submitted to the main branch first and then cherry picked to stable branches. However MTL fbea59358d06 has been made in stable-v2.7 first so the LNL change was also in stable-v2.7 first for consistency. Signed-off-by: Marc Herbert <marc.herbert@intel.com> (cherry picked from commit 469102a8f6052ce6a374b870ea945a84d04c3b1a)
This patch adds sof-mtl-rt722-l0.tplg, which is used to support MTL RVP + RT722 EVB combination. Headphone, speaker and DMIC functions are verified with this topology. Signed-off-by: Chao Song <chao.song@linux.intel.com>
Change domain_types to DP, and allow it to run all 3 cores. Signed-off-by: Yong Zhi <yong.zhi@intel.com>
In non sdw-dmic case, dai incremental id without it, so correct HDMI1/2/3_ID sequence from default 5,6,7 to 4,5,6. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
36066e5 to
fd06766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapping HDMI_ID sequence because dai id creation without sdw-dmic.