Enhance build system and eliminate compiler warnings (#3) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed all compiler warnings by: - Fixed variable type mismatches in function parameters - Properly handled unused variables with appropriate casts - Corrected format string specifiers for various platform compatibility - Ensured consistent return values in all code paths - Added explicit initialization for potentially uninitialized variables Build now completes cleanly without warnings on standard compiler settings. Signed-off-by: editheman <edipana0409@gmail.com>
Created a robust Makefile that: - Adds proper OpenSSL detection via pkg-config with intelligent fallbacks - Supports multiple platforms with OS-specific adaptations - Handles common macOS package locations (Homebrew and MacPorts) - Implements flexible compiler settings with strict warning flags - Includes a dedicated debug target for development - Ensures clean builds with proper dependencies This ensures vfdecrypt builds consistently across different environments without manual configuration. Signed-off-by: editheman <edipana0409@gmail.com>
razvand
requested changes
Dec 5, 2025
Member
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Use a single commit. Squash both commits into a single one.
Are the Makefile and vfdecrypt.c picked up from somewhere else? If so, please mention the source.
Is this a draft PR? A draft PR is one where the author needs to do future work. Is this requiring future work from you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly improves the build reliability of vfdecrypt across different platforms and eliminates all compiler warnings for a clean build experience.
Changes
1. Improved Makefile for cross-platform compatibility
Created a robust Makefile that:
pkg-configwith intelligent fallbacks2. Fixed compiler warnings in code
Addressed all compiler warnings by:
Benefits