Skip to content

[DPG] Please consider the following formatting changes to #13098 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mapalhares merged 1 commit into from
Sep 24, 2025
Merged

[DPG] Please consider the following formatting changes to #13098 #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions DPG/Tasks/AOTTrack/qaMatchEff.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,7 +1390,7 @@
/// Using pt calculated at the inner wall of TPC
/// Caveat: tgl still from tracking: this is not the value of tgl at the
/// inner wall of TPC
return track.tpcInnerParam() / sqrt(1.f + track.tgl() * track.tgl());

Check failure on line 1393 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
}

/// Function applying the kinematic selections
Expand Down Expand Up @@ -1544,7 +1544,7 @@
//
// here n of clusters of TPC assigned to float for histos (and to hack it if needed) :)
//
Float_t clustpc = (Float_t)track.tpcNClsFound();

Check failure on line 1547 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
// Float_t findcltpc = (Float_t)track.tpcNClsFindable();
// Float_t crowstpc = (Float_t)track.tpcNClsCrossedRows();
// Float_t finclusmincrotpc = (Float_t)track.tpcNClsFindableMinusCrossedRows();
Expand All @@ -1561,7 +1561,7 @@
countData++;
//
// keep sign of track
Int_t signOfTrack = track.signed1Pt() > 0 ? 1 : -1;

Check failure on line 1564 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
//
// PID sigmas
if constexpr (!IS_MC) {
Expand Down Expand Up @@ -1599,15 +1599,15 @@
if constexpr (IS_MC) {
auto mcpart = track.mcParticle();
siPDGCode = mcpart.pdgCode();
tpPDGCode = TMath::Abs(siPDGCode);

Check failure on line 1602 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
if (mcpart.isPhysicalPrimary()) {
// histos.get<TH1>(HIST("MC/control/etahist_diff"))->Fill(mcpart.eta() - track.eta());
auto delta = mcpart.phi() - track.phi();
if (delta > PI) {
delta -= TwoPI;

Check failure on line 1607 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[two-pi-add-subtract] 

Use RecoDecay::constrainAngle to restrict angle to a given range.
}
if (delta < -PI) {
delta += TwoPI;

Check failure on line 1610 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[two-pi-add-subtract] 

Use RecoDecay::constrainAngle to restrict angle to a given range.
}
// histos.get<TH1>(HIST("MC/control/phihist_diff"))->Fill(delta);
}
Expand Down Expand Up @@ -1683,7 +1683,7 @@
if (makethn) {
if constexpr (IS_MC) {
histos.fill(HIST("MC/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), specind, signOfTrack, hasdet);
if (siPDGCode == 211 || siPDGCode == 321) // pions and kaons together

Check failure on line 1686 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
histos.fill(HIST("MC/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), 10, signOfTrack, hasdet);
} else {
histos.fill(HIST("data/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), specind, signOfTrack, hasdet);
Expand All @@ -1700,7 +1700,7 @@
if (makethn) {
if constexpr (IS_MC) {
histos.fill(HIST("MC/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), specind, signOfTrack, hasdet);
if (siPDGCode == 211 || siPDGCode == 321) // pions and kaons together

Check failure on line 1703 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
histos.fill(HIST("MC/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), 10, signOfTrack, hasdet);
} else {
histos.fill(HIST("data/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), specind, signOfTrack, hasdet);
Expand All @@ -1717,7 +1717,7 @@
if (makethn) {
if constexpr (IS_MC) {
histos.fill(HIST("MC/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), specind, signOfTrack, hasdet);
if (siPDGCode == 211 || siPDGCode == 321) // pions and kaons together

Check failure on line 1720 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
histos.fill(HIST("MC/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), 10, signOfTrack, hasdet);
} else {
histos.fill(HIST("data/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), specind, signOfTrack, hasdet);
Expand All @@ -1734,7 +1734,7 @@
if (makethn) {
if constexpr (IS_MC) {
histos.fill(HIST("MC/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), specind, signOfTrack, hasdet);
if (siPDGCode == 211 || siPDGCode == 321) // pions and kaons together

Check failure on line 1737 in DPG/Tasks/AOTTrack/qaMatchEff.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
histos.fill(HIST("MC/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), 10, signOfTrack, hasdet);
} else {
histos.fill(HIST("data/sparse/thnsforfrac"), track.dcaXY(), track.dcaZ(), trackPt, track.eta(), sayPrim, track.phi(), specind, signOfTrack, hasdet);
Expand Down Expand Up @@ -3302,7 +3302,7 @@
if (doDebug)
LOGF(info, "Event selection not passed to ITSROFrame border, skipping...");
return;
}
}
if (!collision.selection_bit(aod::evsel::kIsTriggerTVX) && !collision.selection_bit(aod::evsel::kNoTimeFrameBorder)) {
if (doDebug)
LOGF(info, "Event selection not passed to TriggerTVX and TFBorder, skipping...");
Expand Down Expand Up @@ -3330,7 +3330,7 @@
if (doDebug)
LOGF(info, "Event selection not passed to ITSROFrame border, skipping...");
return;
}
}
if (!collision.selection_bit(aod::evsel::kIsTriggerTVX) && !collision.selection_bit(aod::evsel::kNoTimeFrameBorder)) {
if (doDebug)
LOGF(info, "Event selection not passed to TriggerTVX and TFBorder, skipping...");
Expand Down Expand Up @@ -3361,7 +3361,7 @@
if (doDebug)
LOGF(info, "Event selection not passed to ITSROFrame border, skipping...");
return;
}
}
if (!collision.selection_bit(aod::evsel::kIsTriggerTVX) && !collision.selection_bit(aod::evsel::kNoTimeFrameBorder)) {
if (doDebug)
LOGF(info, "Event selection not passed to TriggerTVX and TFBorder, skipping...");
Expand Down Expand Up @@ -3397,7 +3397,7 @@
if (doDebug)
LOGF(info, "Event selection not passed to ITSROFrame border, skipping...");
return;
}
}
if (!collision.selection_bit(aod::evsel::kIsTriggerTVX) && !collision.selection_bit(aod::evsel::kNoTimeFrameBorder)) {
if (doDebug)
LOGF(info, "Event selection not passed to TriggerTVX and TFBorder, skipping...");
Expand Down Expand Up @@ -3428,7 +3428,7 @@
if (doDebug)
LOGF(info, "Event selection not passed to ITSROFrame border, skipping...");
return;
}
}
if (!collision.selection_bit(aod::evsel::kIsTriggerTVX) && !collision.selection_bit(aod::evsel::kNoTimeFrameBorder)) {
if (doDebug)
LOGF(info, "Event selection not passed to TriggerTVX and TFBorder, skipping...");
Expand Down Expand Up @@ -3474,7 +3474,7 @@
if (doDebug)
LOGF(info, "Event selection not passed to ITSROFrame border, skipping...");
return;
}
}
if (!collision.selection_bit(aod::evsel::kIsTriggerTVX) && !collision.selection_bit(aod::evsel::kNoTimeFrameBorder)) {
if (doDebug)
LOGF(info, "Event selection not passed to TriggerTVX and TFBorder, skipping...");
Expand Down
Loading