Skip to content

Conversation

@marcodejongh
Copy link
Owner

The queue climb history wasn't displaying because when getLogbook was
called before wsAuthToken was available, the fetch would fail silently
but fetchedUuidsRef was still set. This prevented the retry when the
token became available.

Changes:

  • getLogbook now returns a boolean indicating fetch success
  • fetchedUuidsRef is only set when the fetch actually succeeds
  • Updated tests to reflect the new return type

The queue climb history wasn't displaying because when getLogbook was
called before wsAuthToken was available, the fetch would fail silently
but fetchedUuidsRef was still set. This prevented the retry when the
token became available.

Changes:
- getLogbook now returns a boolean indicating fetch success
- fetchedUuidsRef is only set when the fetch actually succeeds
- Updated tests to reflect the new return type
@vercel
Copy link

vercel bot commented Jan 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
boardsesh Building Building Jan 3, 2026 7:05am

@claude
Copy link

claude bot commented Jan 3, 2026

Claude Review

Ready to merge - Minor issues noted below, but nothing blocking.

Issues

  1. Missing test for retry behavior - The tests mock getLogbook to always return true, but there's no test verifying that when getLogbook returns false, the fetchedUuidsRef is NOT set, allowing a retry on subsequent calls. This is the core behavior this PR is fixing.

  2. Unhandled promise rejection - use-queue-data-fetching.tsx:271: The .then() callback doesn't have a .catch() handler. If getLogbook throws an exception (rather than returning false), the promise rejection will be unhandled. Consider adding .catch(() => {}) or using the existing try/catch in fetchLogbook to ensure it always returns a boolean.

@marcodejongh marcodejongh merged commit 72d979e into main Jan 3, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants