-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Add DH and ECDH support #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
athexweb3
wants to merge
12
commits into
margelo:main
Choose a base branch
from
athexweb3:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+12,319
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix EOF line ending in .gitignore - Add react-native-nitro-modules to all installation instructions - Update performance claims from '58x' to 'hundreds of times faster' - Reframe JSI mentions to focus on Nitro Modules architecture - Add libsodium/xsalsa20 configuration documentation
- Change Simple Random Strings to suggest react-native-get-random-values for random-only use cases - Update comparison title from JSI to Nitro - Add benchmark philosophy note explaining comparison context
- Add comprehensive 'Contributing' and 'Writing Documentation' guides to the website. - Update `CONTRIBUTING.md` with instructions for updating feature coverage. - Update [README.md](/README.md:0:0-0:0) with links to the new documentation guides. - Add theme-aware banner images to the Quick Start page. - Standardize documentation structure guidelines.
- Fix broken table formatting in 'What is RNQC?' introduction page.
# Conflicts: # .docs/img/expo/light.png # .gitignore # README.md # docs/img/expo.png # docs/img/expo/light.png
|
Looking forward to this |
Contributor
Author
|
Brad bro is busy currently. hope he will review this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add DH and ECDH support with benchmarks
Description
This PR implements full support for Diffie-Hellman (DH) and Elliptic Curve Diffie-Hellman (ECDH) key exchanges in react-native-quick-crypto, complete with C++ native implementations, benchmarks, and comprehensive tests.
Changes
Core Implementation
Diffie-Hellman (DH):
DiffieHellmanclass mirroring the Node.js API (createDiffieHellman,getDiffieHellman).EVP_PKEYfor key generation and shared secret derivation.Elliptic Curve Diffie-Hellman (ECDH):
ECDHclass mirroring the Node.js API (createECDH).EC_KEYandEVP_PKEY.secp256k1,prime256v1, and others.Benchmarks & Tests
Benchmarks:
crypto-browserify(where applicable) and native baselines.Tests:
Added comprehensive test coverage validating:
Verification
Checklist
cryptoAPI.main(synced with release1.0.6).