-
Notifications
You must be signed in to change notification settings - Fork 6
Add CircleCI test-splitting workflow #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tsharmaMW
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this workflow! It’s going to be very helpful for our users.
|
Overall looks good but is CircleCI connected to this repository? I can't find the jobs on Circle to verify the workflows are running as expected. |
mw-hrastega
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting some minor tweaks.
| linux-with-latest: | ||
| imageName: ubuntu-latest | ||
| release: latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use the latest keyword, I've updated the identifier to linux-with-latest (as simply linux-latest could be misleading). Does anyone have a better name or is this fine?
There are multiple CircleCI pipelines in this repository (with custom names instead of the general |
The mathworks/ci-configuration-examples repo has the CircleCI app, so I would think we can get it on this repo as well. I am not a repo admin, so I can't attempt to set up Circle for this repo but what are you running into when you try? We can get in touch with the MathWorks org admin if we need to. |
NOTE: CircleCI's free plan doesn't support parallelism for macOS cloud runners. Hence those users won't be able to use test-splitting with the current workflow's mac executor configuration. Decided not to add this info as a comment in our workflow since it will increase maintenance burden.