Skip to content

Conversation

@tsteur
Copy link
Member

@tsteur tsteur commented Nov 24, 2025

Description

Fixes #136

Historically, QueuedTracking disabled the Provider plugin because provider lookups were slow when executed during the tracking request. That context has changed.

The plugin was not enabled by default in core and had to be enabled. Provider plugin is no longer part of core and must be explicitly installed from the Marketplace. When a user installs and enables the plugin, it’s a strong signal that they want provider data.

QueuedTracking’s blanket disabling of Provider leads to unexpected missing data for users who clearly opted in.

Additionally, performance concerns are no longer a good reason to disable the plugin:

  • With an ASN database configured, Provider lookups are fast (this is also how we run it on Cloud).
  • Even without an ASN database, Provider lookups executed in the queue won’t be any slower than in normal, synchronous tracking. In fact, overall performance will still be better.

Given these points, there’s no longer a justification for QueuedTracking to disable Provider automatically. This PR removes that behavior so users get the data they explicitly enabled.

Issue No

Fixes #136

Checklist

  • [✔/✖] Tested locally or on demo2/demo3?
  • [✔/✖/NA] New test case added/updated?
  • [✔/✖/NA] Are all newly added texts included via translation?
  • [✔/✖/NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔/✖/NA] Version bumped?

AltamashShaikh
AltamashShaikh previously approved these changes Nov 25, 2025
@AltamashShaikh AltamashShaikh merged commit d5fbd3e into 5.x-dev Nov 25, 2025
7 checks passed
@AltamashShaikh AltamashShaikh deleted the q136 branch November 25, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new setting to enable/disable Provider reverse dns lookup

3 participants