added Xunit #5
Open
added Xunit #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
requested changes
May 27, 2017
Collaborator
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Существует тысяча способов написать неправильный тест, и библиотека должна помогать программисту найти проблему, если он это сделает. У Вас же только ловится throwable и печатается стектрейс, и нет ни одного теста на плохие случаи (например, отсутствие конструктора без аргументов или наличие аргументов в тестовом методе).
| import java.util.Spliterator; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.Stream; | ||
| import java.util.stream.StreamSupport; |
Collaborator
There was a problem hiding this comment.
Тут куча ненужных import-ов, говорит IDEA
| @@ -0,0 +1,62 @@ | |||
| package task.Tester; | |||
Collaborator
There was a problem hiding this comment.
Имя пакета какое-то неканоничное
| Class<?> clazz = classLoader.loadClass(name); | ||
| classes.add(clazz); | ||
| } catch (ClassNotFoundException e) { | ||
| // e.printStackTrace(); |
| import org.jetbrains.annotations.NotNull; | ||
| import task.annotations.*; | ||
|
|
||
| import javax.sound.midi.SysexMessage; |
| for (Method method : methods) { | ||
| for (Annotation annotation : method.getAnnotations()) { | ||
| Class<? extends Annotation> key = annotation.annotationType(); | ||
| if (annotatedMethods.get(annotation.annotationType()) != null) { |
Collaborator
There was a problem hiding this comment.
Это же как раз key?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.