Skip to content

Conversation

@wmaciejewskimer
Copy link
Collaborator

No description provided.

Tomasz Szymański and others added 4 commits March 25, 2022 23:40
…o DR2-98-replace-drf-settings

# Conflicts:
#	trench/backends/application.py
#	trench/backends/basic_mail.py
#	trench/backends/sms_api.py
#	trench/backends/twilio.py
#	trench/backends/yubikey.py
#	trench/settings.py
@wmaciejewskimer wmaciejewskimer changed the title Dr2 98 replace drf settings DR2-98 | Replace drf settings Dec 29, 2022
@codebutler
Copy link

codebutler commented Feb 1, 2023

@wmaciejewskimer Hi, could this please be merged in soon? There's a bug in the latest release that prevents defining custom backends, and I confirmed this PR fixes it.

The bug is here:

TypeError: 'str' object is not callable

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potentially incorrect use of DRF's APISettings that makes it impossible to add a custom 2FA backend

3 participants