Skip to content

fix include path #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Carlosespicur merged 2 commits into from
Sep 30, 2025
Merged

fix include path #781

Carlosespicur merged 2 commits into from
Sep 30, 2025

Conversation

@DedSecer
Copy link
Contributor

@DedSecer DedSecer commented Jun 9, 2025

fix include path for #664

@DedSecer DedSecer requested a review from pablogs9 as a code owner June 9, 2025 13:31
@Carlosespicur
Trigger CI
c9e99f3 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Carlosespicur
Carlosespicur approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@Carlosespicur Carlosespicur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Carlosespicur Carlosespicur merged commit 22cf5e0 into micro-ROS:humble Sep 30, 2025
20 checks passed
@4ntn
Copy link
Contributor

4ntn commented Sep 30, 2025

@mergify backport jazzy kilted rolling

@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2025 •
edited
Loading

backport jazzy kilted rolling

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Sep 30, 2025
@DedSecer @Carlosespicur @mergify
fix include path (#781)
f9b1cb2 
* fix include path

* Trigger CI

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 22cf5e0)
mergify bot pushed a commit that referenced this pull request Sep 30, 2025
@DedSecer @Carlosespicur @mergify
fix include path (#781)
211b449 
* fix include path

* Trigger CI

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 22cf5e0)
This was referenced Sep 30, 2025
Closed
Merged
mergify bot pushed a commit that referenced this pull request Sep 30, 2025
@DedSecer @Carlosespicur @mergify
fix include path (#781)
61bd2ad 
* fix include path

* Trigger CI

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 22cf5e0)
@mergify mergify bot mentioned this pull request Sep 30, 2025
Closed
EugenioCollado pushed a commit that referenced this pull request Oct 16, 2025
@DedSecer @Carlosespicur @EugenioCollado
fix include path (#781)
34d7d32 
* fix include path

* Trigger CI

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 22cf5e0)
EugenioCollado pushed a commit that referenced this pull request Oct 16, 2025
@DedSecer @Carlosespicur @EugenioCollado
fix include path (#781)
3c59783 
* fix include path

* Trigger CI

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 22cf5e0)
@brandonho667
Copy link

brandonho667 commented Nov 20, 2025 •
edited
Loading

mcu_ws doesn't exist if you're building on $RTOS=host (https://github.com/micro-ROS/micro_ros_setup/blob/humble/scripts/create_firmware_ws.sh#L89)

EugenioCollado added a commit that referenced this pull request Dec 9, 2025
@mergify @DedSecer
@Carlosespicur @EugenioCollado
fix include path (#790)
52d6a34 
* fix include path (#781)

* fix include path

* Trigger CI

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 22cf5e0)

* Remove rsync & execute only in non-host scenario

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: DedSecer <ded5ec@icloud.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Eugenio Collado <eugeniocollado@eprosima.com>
mergify bot added a commit that referenced this pull request Dec 9, 2025
@mergify @DedSecer
@Carlosespicur @EugenioCollado
fix include path (#790)
c8d71f6 
* fix include path (#781)

* fix include path

* Trigger CI

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 22cf5e0)

* Remove rsync & execute only in non-host scenario

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: DedSecer <ded5ec@icloud.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Eugenio Collado <eugeniocollado@eprosima.com>
(cherry picked from commit 52d6a34)
mergify bot added a commit that referenced this pull request Dec 9, 2025
@mergify @DedSecer
@Carlosespicur @EugenioCollado
fix include path (#790)
393a330 
* fix include path (#781)

* fix include path

* Trigger CI

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 22cf5e0)

* Remove rsync & execute only in non-host scenario

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: DedSecer <ded5ec@icloud.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Eugenio Collado <eugeniocollado@eprosima.com>
(cherry picked from commit 52d6a34)
This was referenced Dec 9, 2025
Merged
Merged
EugenioCollado added a commit that referenced this pull request Dec 9, 2025
@mergify @DedSecer
@Carlosespicur @EugenioCollado
fix include path (#790) (#801)
526d0c5 
* fix include path (#781)

* fix include path

* Trigger CI



---------



(cherry picked from commit 22cf5e0)

* Remove rsync & execute only in non-host scenario



---------






(cherry picked from commit 52d6a34)

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: DedSecer <ded5ec@icloud.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Eugenio Collado <eugeniocollado@eprosima.com>
EugenioCollado added a commit that referenced this pull request Dec 9, 2025
@mergify @DedSecer
@Carlosespicur @EugenioCollado
fix include path (backport #781) (backport #790) (#800)
03aa3c1 
* fix include path (#790)

* fix include path (#781)

* fix include path

* Trigger CI

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit 22cf5e0)

* Remove rsync & execute only in non-host scenario

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: DedSecer <ded5ec@icloud.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Eugenio Collado <eugeniocollado@eprosima.com>
(cherry picked from commit 52d6a34)

* Compile service_msgs

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Compile unique_identifier_msgs

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: DedSecer <ded5ec@icloud.com>
Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Eugenio Collado <eugeniocollado@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Carlosespicur Carlosespicur Carlosespicur approved these changes

@pablogs9 pablogs9 Awaiting requested review from pablogs9 pablogs9 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DedSecer @4ntn @brandonho667 @Carlosespicur