Skip to content

Enable pyright checks with min dependencies #7623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenshnielsen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable pyright checks with min dependencies #7623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dffd3c3
Enable pyright with min dependencies
jenshnielsen Nov 5, 2025
ebb622f
Bump dependencies
jenshnielsen Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pytest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
uses: jakebailey/pyright-action@6cabc0f01c4994be48fd45cd9dbacdd6e1ee6e5e # v2.3.3
with:
version: ${{ steps.pyright-version.outputs.version }}
if: ${{ !matrix.min-version && always() }}
if: ${{ always() }}
id: pyright
- name: Run Mypy
run: mypy -p qcodes
Expand Down
12 changes: 6 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ dependencies = [
"ipywidgets>=8.0.0,<9.0.0",
"ipykernel>=6.12.0", # implicitly required by ipywidgets >=8.0.5
"jsonschema>=4.9.0",
"matplotlib>=3.6.0",
"matplotlib>=3.8.0",
"networkx>=3.1",
"numpy>=1.22.4",
"packaging>=20.0",
Expand All @@ -42,10 +42,10 @@ dependencies = [
"tqdm>=4.59.0",
"uncertainties>=3.2.0",
"versioningit>=2.2.1",
"websockets>=11.0",
"websockets>=13.0",
"xarray>=2023.08.0",
"cf_xarray>=0.8.4",
"opentelemetry-api>=1.17.0",
"opentelemetry-api>=1.25.0",
"pillow>=9.2.0",
"dask>=2022.1.0", # we are making use of xarray features that requires dask implicitly
]
Expand All @@ -60,7 +60,7 @@ Tracker = "https://github.com/microsoft/Qcodes/issues"
Changelog = "https://microsoft.github.io/Qcodes/changes/index.html"

[project.optional-dependencies]
zurichinstruments = ["zhinst-qcodes>=0.3"]
zurichinstruments = ["zhinst-qcodes>=0.5"]
loop = ["qcodes_loop>=0.1.2"]
test = [
"coverage[toml]>=7.10.5",
Expand All @@ -79,13 +79,13 @@ test = [
"PyVisa-sim>=0.6.0",
"sphinx>=4.5.0", # sphinx extension tests
"types-jsonschema>=4.16.0",
"types-networkx >= 3.1", # Version should match the networkx requirment
"types-networkx >= 3.5.0.20251104",
"types_requests>=0.1.8",
"types-tabulate>=0.1.0",
"types-tqdm>=4.64.6",
"types_pywin32>=305.0.0.7",
"qcodes_loop>=0.1.1",
"zhinst.qcodes>=0.5", # typecheck zhinst driver alias
"zhinst-qcodes>=0.5", # typecheck zhinst driver alias
"libcst>=1.2.0", # refactor tests
]
docs = [
Expand Down
Loading