Skip to content

Migrate StructuredSerializeOptions #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Dec 26, 2025
+12 −15
Merged

Migrate StructuredSerializeOptions #2327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions inputfiles/knownTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"RTCStatsIceCandidatePairState",
"RTCStatsType",
"RTCTransportStats",
"Transferable",
"ValueTypeMap",
"VideoFacingModeEnum"
],
Expand Down Expand Up @@ -91,12 +90,10 @@
"RsaKeyGenParams",
"RsaOaepParams",
"RsaPssParams",
"Transferable",
"ValueTypeMap"
],
"Worklet": [
"EventListenerOrEventListenerObject",
"Transferable",
"ValueTypeMap"
]
}
9 changes: 0 additions & 9 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3319,15 +3319,6 @@
},
"dictionaries": {
"dictionary": {
"StructuredSerializeOptions": {
"members": {
"member": {
"transfer": {
"overrideType": "Transferable[]"
}
}
}
},
"MessageEventInit": {
"members": {
"member": {
Expand Down
8 changes: 8 additions & 0 deletions inputfiles/patches/html.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ interface HTMLImageElement {
property loading overrideType=#""eager" | "lazy""#
}

dictionary StructuredSerializeOptions {
member transfer {
type {
type Transferable
}
}
}

removals {
dictionary CanvasRenderingContext2DSettings {
member colorType // Blink-only as of 2025-12, being tested in WebKit
Expand Down
7 changes: 4 additions & 3 deletions src/build/patches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ function handleMethodAndConstructor(
*/
function handleDictionary(child: Node): DeepPartial<Dictionary> {
const name = string(child.values[0]);
const member: Record<string, Partial<Member>> = {};
const member: Record<string, DeepPartial<Member>> = {};
let typeParameters = {};

for (const c of child.children) {
Expand Down Expand Up @@ -411,11 +411,12 @@ function handleDictionary(child: Node): DeepPartial<Dictionary> {
* Handles dictionary member nodes
* @param c The member node to handle.
*/
function handleMember(c: Node): Partial<Member> {
function handleMember(c: Node): DeepPartial<Member> {
const name = string(c.values[0]);
const typeNodes = c.children.filter((c) => c.name === "type");
return {
name,
...optionalMember("type", "string", c.properties?.type),
...handleTyped(typeNodes, c.properties?.type),
...optionalMember("required", "boolean", c.properties?.required),
...optionalMember("deprecated", "string", c.properties?.deprecated),
...optionalMember("overrideType", "string", c.properties?.overrideType),
Expand Down