Skip to content

Migrate EventListenerObject to KDL #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
Dec 27, 2025
+13 −20
Merged

Migrate EventListenerObject to KDL #2328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a373387
Migrate EventListenerObject
Bashamega Dec 27, 2025
1d2ef4b
Change return type of EventListener methods to undefined
saschanaz Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions inputfiles/addedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,19 +234,6 @@
"extends": "DOMRect",
"noInterfaceObject": true
},
"EventListenerObject": {
"name": "EventListenerObject",
"noInterfaceObject": true,
"methods": {
"method": {
"handleEvent": {
"overrideSignatures": [
"handleEvent(object: Event): void"
]
}
}
}
},
"Document": {
"methods": {
"method": {
Expand Down
20 changes: 13 additions & 7 deletions inputfiles/patches/dom.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
// Keeping EventListener and EventListenerObject isn't the most elegant way to handle the event listeners, but we need to keep the EventListener as an extendable interface for libraries like angular.
interface EventListener noInterfaceObject=#true {
method "" returns=void {
param evt type=Event
}
method "" returns=undefined {
param evt type=Event
}
}

interface EventListenerObject noInterfaceObject=#true {
method handleEvent returns=undefined {
param object type=Event
}
}

enum InsertPosition {
beforebegin
beforeend
afterbegin
afterend
beforebegin
beforeend
afterbegin
afterend
}

// ChildNode and ParentNode are actually defined as mixins, but because of their names they have historically been used as a sub-interface of Node.
Expand Down