-
Notifications
You must be signed in to change notification settings - Fork 1k
Python: Add declarative workflow runtime #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
python/packages/declarative/agent_framework_declarative/_workflows/_factory.py
Outdated
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_factory.py
Outdated
Show resolved
Hide resolved
python/samples/getting_started/workflows/declarative/conditional_workflow/main.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the comments so far. I will finish the review later today, or tomorrow if I can't get to all of it.
python/packages/declarative/agent_framework_declarative/_workflows/_graph/__init__.py
Outdated
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_graph/_base.py
Outdated
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_graph/_builder.py
Outdated
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_declarative_builder.py
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_declarative_builder.py
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_declarative_builder.py
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_graph/_builder.py
Outdated
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_declarative_base.py
Outdated
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_executors_agents.py
Outdated
Show resolved
Hide resolved
python/packages/core/agent_framework/_workflows/_workflow_builder.py
Outdated
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_executors_external_input.py
Outdated
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_factory.py
Show resolved
Hide resolved
python/packages/declarative/agent_framework_declarative/_workflows/_handlers.py
Show resolved
Hide resolved
| # Get input schema information | ||
| input_schema = {} | ||
| # First, check if the workflow has an explicit input_schema (e.g., declarative workflows) | ||
| input_schema: dict[str, Any] = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victordibia I had to do some changes here to get declarative workflows to parse properly... can you have a look please? Not sure how it'll jive with your current DevUI PR you have open. Thanks.
|
@eavanvalkenburg @TaoChenOSU did a lot of clean up here. Thanks for the thorough reviews. Please have a look again. |
eavanvalkenburg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of comments, and would also be useful to have a sample showing the workflow in the code itself.
Motivation and Context
Adds a graph-based runtime for executing declarative YAML workflows, enabling multi-agent orchestration without writing Python code.
Features
Samples
Description
Contribution Checklist