Skip to content

Conversation

@aviatco
Copy link
Collaborator

@aviatco aviatco commented Jan 6, 2026

✨ Description of new changes

fix #117
This pull request updates the logic for handling optional parameters in connection creation methods, ensuring that parameters and credentials are only included in the request when required. It also adds targeted tests to verify correct handling of optional and required parameters, as well as credential types that do not require parameters.

Core logic improvements:

  • Updated get_connection_config_from_params in fab_cmd_mkdir_utils.py to only require and include parameters for connection creation methods if they are actually needed, and to properly handle credential types that do not require additional parameters (e.g., WorkspaceIdentity). [1] [2] [3]

Testing enhancements:

  • Added tests in test_fab_cmd_mkdir_utils.py to verify:
    • Success when no parameters are required for a connection method or credential type.
    • Failure when required parameters are missing, confirming correct error messaging.
    • That unsupported parameters for WorkspaceIdentity are ignored and a warning is issued.

Documentation:

  • Added a changelog entry describing that creation-method parameters are now optional. (.changes/unreleased/fixed-20260106-132043.yaml)# 📥 Pull Request

@aviatco aviatco requested a review from a team as a code owner January 6, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] connection creation logic doesn't properly handle connection types where the creation method has no parameters

1 participant