Skip to content

refac(ComponentProvider): omit duplication #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bougwal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refac(ComponentProvider): omit duplication #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions packages/micro-frontend-react/src/ComponentProvider/ComponentProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,13 @@ export class ComponentProvider extends React.Component<IComponentProviderProps,
};

public async componentDidMount(): Promise<void> {
const component = await this.loadComponent();

this.setState({
Component: component,
hasError: false,
});
this.updateStateOnLoad();
}

public async componentDidUpdate(prevProps: IComponentProviderProps): Promise<void> {
const { config } = prevProps;

if (this.shouldReload(config)) {
const component = await this.loadComponent();

this.setState({
Component: component,
hasError: false,
});
this.updateStateOnLoad();
}
}

Expand Down Expand Up @@ -166,4 +155,13 @@ export class ComponentProvider extends React.Component<IComponentProviderProps,

return true;
}

private async updateStateOnLoad(): Promise<void> {
const component = await this.loadComponent();

this.setState({
Component: component,
hasError: false,
});
}
}